1539324 - Display 40 digit hashes

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect, P1)

Description

[Paul Bone [:pbone]]

In the web UI, eg pages like:

https://hg.mozilla.org/integration/autoland/rev/1467f14d7dd6bc82b4d445dd6505353069d005ff

The 40 digit hash/id of each revision should be shown. it's more useful to use with perfherder compare that way.

See Bug 1523385 Comment 1

Comment 1

[Connor Sheehan [:sheehan]]

I'm in favor of making this change! 👍

In case someone aside from me takes this bug, we will need to modify the Mercurial templates for gitweb_mozilla to change all instances of {node|short} to just {node}. We'll also need to add/modify the patch files in hgtemplates/.patches. This will likely also require a bunch of cosmetic test fixes to add the full hash to output.

Comment 2

[Connor Sheehan [:sheehan]]

I'll be taking care of this after we do the Mercurial 4.9 upgrade on hg.mo (sometime this week).

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: hgtemplates: do not pass `node` through `short` template filter anywhere (Bug 1539324) r?glob,smacleod

Treeherder has removed support for using 12 character revision
SHAs, due to the performance hit taken by being unable to fully
index a 12 character SHA (since the 40 character SHA is the
canonical version). This commit performs a global replace of
{node|short} with {node} for the gitweb_mozilla theme.

The existing form takes the node template keyword and passes
it through the short template filter, producing the 12-character
SHA. Removing the short filter will cause the full 40-char
SHA to be displayed instead.

Like all other templating changes, we add a patchfile to
hgtemplates/.patches that encompasses all the changes made by
this commit. Running hgserver/tests/test-template-sync.t
verified that the changes are successfully tracked under version
control.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/51905dc214c4
hgtemplates: do not pass node through short template filter anywhere r=glob

Comment 5

[Connor Sheehan [:sheehan]]

Deploying this change to hg.mozilla.org now.

Comment 6

[Connor Sheehan [:sheehan]]

This is live.