1539429 - Enable Storage API for GeckoView

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, enhancement, P3)

Description

[Andrew Overholt [:overholt]]

Can we enable persist() and estimate() in GeckoView without knowing how apps that use GeckoView will expose associated UI?

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Maybe we don't necessarily want user consent, but instead some API that allows apps to specify the amount of storage available? They could of course set that based on user input if they wish. We'd also need some stuff to allow apps to inspect the storage used for each origin and clear that, etc.

I don't really think it's too useful to prompt for each site, but I'd welcome input from the UX folks on that.

Comment 2

[Andrew Overholt [:overholt]]

There are a variety of APIs available from the QuotaManager that we could potentially expose via custom GV APIs. Agreed that it probably needs UX input.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Hmm, I'm not sure who we can NI from UX. Anthony, maybe you can help?

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Hey James, maybe Shorlander since he's been working on Fenix? He has most of the context here.

Comment 5

[Emily Toop (:fluffyemily)]

This is related to the work I've been looking at for https://bugzilla.mozilla.org/show_bug.cgi?id=1527074, which is essentially wiring up persist() and ensuring it asks for Android and user permissioning.

Comment 6

[Chris Peterson [:cpeterson]]

Emily is looking at storage permissions bug 1527074. Priority P3 because this feature is not needed for Fenix MVP.

The test runner app will need to accept storage requests.

Comment 7

[Emily Toop (:fluffyemily)]

resolved by 1547100 & 1527074

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Emily Toop (:fluffyemily) from comment #7)

resolved by 1547100 & 1527074

^ Just to be clear, those bug fixes were for Storage API test failures, not enabling the Storage API.

Comment 9

[Emily Toop (:fluffyemily)]

So, bug 1527074 enabled the Storage API and bug 1547100 enabled the tests that ensure that persist and estimate work.