1539538 - Add validity checks to containers of bare pointers in IDB and LS

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, enhancement, P2)

Description

[Yaron Tausky [:ytausky]]

We have several containers storing bare pointers to refcounted objects. In the interest of preventing both invalid dereferencing and hanging because of a dangling entry, we should add optional assertions that verify that these pointers get removed before their pointees are destructed.

Comment 1

[Jan Varga [:janv]]

Yeah, we need this ASAP.

Comment 2

[Yaron Tausky [:ytausky]]

Attachment: Introduce UnsafePtr

This commit adds a smart pointer class that verifies that no dangling
pointers remain after the pointee went out of scope. This verification is
opt-in and can be controlled both statically and dynamically by the pointee.

Comment 4

[Jan Varga [:janv]]

It would be nice to incorporate patches from this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=725b8386948bb6010f72b6fa53f8e327c4bab9d1
unsafeptr-hash and unsafeptr-idb

unsafeptr-hash needs to be polished, I just quickly created MyHashtable to avoid problems with memmove()

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de1c51fce80e
Introduce UnsafePtr r=froydnj,janv

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/de1c51fce80e