1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Dennis Schubert [:denschub]]

As reported here, there is a dot where it shouldn't be, which prevents *.officeapps-df.live.com to actually be fixed. Let's remove that dot.

(This may be the wrong component, but since the pref is DOM Event related, and the other bugs are filed here as well, it seemed fitting. Feel free to move.)

Comment 1

[Dennis Schubert [:denschub]]

Attachment: Bug 1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref. r=miketaylr

Comment 2

[Dennis Schubert [:denschub]]

[Tracking Requested - why for this release]:

This fixes the list of domains from bug 1538966, so this needs to be in the .3 dotrelease as well. Sorry.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17a6bdaedd65
Remove superfluous dot from use_legacy_keycode_and_charcode pref. r=miketaylr

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/17a6bdaedd65

Comment 5

[Dennis Schubert [:denschub]]

Comment on attachment 9054011 [details]
Bug 1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref. r=miketaylr

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1538966
• User impact if declined: This fixes the domain list we added in bug 1538966, but added an additional point. If this doesn't get uplifted, *.officeapps-df.live.com will not be fixed.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1538970
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Amending an already shipped pref-only change
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9054011 [details]
Bug 1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref. r=miketaylr

Approved for 67 beta 7. I am leaving the approval for release as we don't know yet when we have it. Thanks.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d8560229d39e

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Counting this as one of the drivers for 66.0.3.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9054011 [details]
Bug 1539618 - Remove superfluous dot from use_legacy_keycode_and_charcode pref. r=miketaylr

OK for uplift for 66.0.3.
Dennis, is there a good way to verify this? I notice in bug 1538966 we did verify that fix.

Comment 10

[Dennis Schubert [:denschub]]

Unfortunately, no. This change only affects office apps running at *.officeapps-df.live.com, and I actually don't know when they do, as I have never seen that domain. It was one of the domains Microsoft sent us, so we could probably ask them if we absolutely want to have a verification here, but at the moment, we can't verify this.

Comment 11

[Bogdan Maris, Desktop Test Engineering]

(In reply to Dennis Schubert [:denschub] from comment #10)

Unfortunately, no. This change only affects office apps running at *.officeapps-df.live.com, and I actually don't know when they do, as I have never seen that domain. It was one of the domains Microsoft sent us, so we could probably ask them if we absolutely want to have a verification here, but at the moment, we can't verify this.

Based on this I will remove the qe-verify+ flag since we can't actually test it.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/70bc92ce18e9

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Noted for 66.0.3 as FIXED: Fix for keypress events in some Microsoft cloud applications

Comment 14

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.