1539702 - Improve CreateClippedDrawTarget API

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

I want to make more of the information internal to Moz2D so that it's easier to make things offset invariant for blob recoordination

Comment 1

[Jeff Muizelaar [:jrmuizel]]

There's bugs with my latest attempt: https://treeherder.mozilla.org/#/jobs?repo=try&revision=437700352696d31b818d3a932134aa474593a1fa&selectedJob=239449442

layout/reftests/svg/svg-integration/clipPath-transformed-html-01.xhtml is probably a good one to tackle first.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

The reftests finally pass: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27ca0c07246c76a7e7551599b7d26401f973b856&selectedJob=248291805

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1539702. Improve CreateClippedDrawTarget API

This changes CreateClippedDrawTarget so that instead of taking
a max size and a transform it just takes a user space rect of
the desired bounds.

This change allows the caller to not worry about the computing
a max size based on the current clip. Instead this responsibility
is lowered into the specific backends.

The main motivation for this work is to allow blob recoordination
to create recordings that don't depend on the current clip.

Some additional benefits are that the API is easier to use and
as can be seen simplifies the SVG masking code because it doesn't
need to track surface offsets manually.

It's also an important step towards removing all the uses of
gfxContext::GetClipExtents which will let us get rid of the separate
clipping stack in gfxContext and help us move off of gfxContext
completely.

Most backend implementations of CreateClippedDrawTarget are relatively
simple. However things are more complicated for DrawTargetCapture
because of its lazy resolution. The solution to this is explained
in the comments at the definition of the ResolveTarget struct.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88e6c989e783
Improve CreateClippedDrawTarget API r=jwatt,rhunt

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for multiple reftest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/7414bfc0414566bb9a9e883e5a54e53a95824eb1
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=252773693&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=88e6c989e78320d6a37671e23b92cc4f68736295
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=252773693&repo=autoland&lineNumber=11527

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba22d4def27f
Improve CreateClippedDrawTarget API r=jwatt,rhunt

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ba22d4def27f

Comment 8

[Florin Strugariu [:Bebe]]

== Change summary for alert #21598 (as of Wed, 26 Jun 2019 05:51:50 GMT) ==

Improvements:

4% raptor-motionmark-htmlsuite-firefox linux64-shippable opt 29.86 -> 30.97

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21598