1539944 - Remove NS_NewThread in favour of NS_NewNamedThread

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

We don't use NS_NewThread much these days (I see it only being used in test code as of current mozilla-central), and I think we should probably remove it.

That way, people have to use NS_NewNamedThread, which is better, since it means that we'll have useful names for threads appear in things like the Gecko Profiler.

Comment 1

[Kris Wright :KrisWright]

Attachment: Bug 1539944 - Get rid of NS_NewThread

Gets rid of NS_NewThread. Where it was used in testing, I gave the named threads names relevant to their tests. I didn't name the crash reporter testing threads because the test runnables set their own names as a part of the testing process.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/541b98270c99
Get rid of NS_NewThread r=froydnj

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 541b98270c99 (bug 1539944) for causing bc leaks
https://hg.mozilla.org/integration/autoland/rev/e188f8d308078010981f61d7a36d6ff089d0900c

push that caused the backout: https://hg.mozilla.org/integration/autoland/rev/541b98270c9985c5bd3569ff3ff8bc6c3d3c650a

failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288435560&repo=autoland&lineNumber=4005

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a62019b3e261
Get rid of NS_NewThread r=froydnj

Comment 5

[Cosmin Sabou [:CosminS]]

Relanded ^

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a62019b3e261