1694462 - Remove nsIThreadManager.newThread API

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Florian Quèze [:florian]]

newNamedThread should be used instead.

The newThread old API is still used at https://searchfox.org/mozilla-central/rev/f47a4b67643b3048ef9a2e2ac0c34edf6d1ebff3/toolkit/components/telemetry/core/Telemetry.cpp#879 and https://searchfox.org/mozilla-central/rev/f47a4b67643b3048ef9a2e2ac0c34edf6d1ebff3/toolkit/xre/ProfileReset.cpp#129

These threads should have names, and then we can remove the API to prevent the addition of more nameless threads.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1694462 - Remove the nsIThreadManager.newThread API (newNamedThread should be used instead), r=Bas.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d7572427d1d
Remove the nsIThreadManager.newThread API (newNamedThread should be used instead), r=bas,KrisWright.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1d7572427d1d

Comment 4

[tustamido]

The removed newThread was scriptable, could you please remove [noscript] from newNamedThread? Thanks.

Comment 5

[Florian Quèze [:florian]]

(In reply to tustamido from comment #4)

The removed newThread was scriptable, could you please remove [noscript] from newNamedThread? Thanks.

Feel free to open a new bug and submit a patch for this change. It would also be nice if you could explain there the use case. My understanding was that JS XPCOM can't be used off-main thread, and that it's the reason why we have the ChromeWorker API.