Closed Bug 1694462 Opened 11 months ago Closed 11 months ago

Remove nsIThreadManager.newThread API

Categories

(Core :: XPCOM, task)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

newNamedThread should be used instead.

The newThread old API is still used at https://searchfox.org/mozilla-central/rev/f47a4b67643b3048ef9a2e2ac0c34edf6d1ebff3/toolkit/components/telemetry/core/Telemetry.cpp#879 and https://searchfox.org/mozilla-central/rev/f47a4b67643b3048ef9a2e2ac0c34edf6d1ebff3/toolkit/xre/ProfileReset.cpp#129

These threads should have names, and then we can remove the API to prevent the addition of more nameless threads.

Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d7572427d1d
Remove the nsIThreadManager.newThread API (newNamedThread should be used instead), r=bas,KrisWright.
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

The removed newThread was scriptable, could you please remove [noscript] from newNamedThread? Thanks.

(In reply to tustamido from comment #4)

The removed newThread was scriptable, could you please remove [noscript] from newNamedThread? Thanks.

Feel free to open a new bug and submit a patch for this change. It would also be nice if you could explain there the use case. My understanding was that JS XPCOM can't be used off-main thread, and that it's the reason why we have the ChromeWorker API.

You need to log in before you can comment on or make changes to this bug.