Closed Bug 1540300 Opened 6 years ago Closed 6 years ago

110,000 instances of "NS_ENSURE_SUCCESS(mStatus, mStatus) failed with result 0x804B000A" and related warnings during linux64 debug testing

Categories

(Firefox :: Protections UI, defect, P1)

Product:
Firefox
Component:
Protections UI
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1540300 - Remove more verbose nsIURIMutator warnings. r=valentin
47 bytes, text/x-phabricator-request
Details | Review

Similar to bug 1515833 we still have quite a few warnings coming out of nsIURIMutator.h.

55124 WARNING: NS_ENSURE_SUCCESS(mStatus, *this) failed with result 0x804B000A: file obj-firefox/dist/include/nsIURIMutator.h, line 472

This warning [1] shows up in the following test suites:

 12509 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
 12493 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
  3339 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
  2708 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
  2013 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
  1457 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
  1334 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
  1299 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
  1274 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   880 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
   880 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
   880 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
   859 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
   824 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
   808 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
   756 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
   754 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
   748 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
   722 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
   722 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
   652 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
   650 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
   602 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
   504 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
   488 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
   472 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
   470 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
   436 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
   382 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
   342 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
   292 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
   284 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
   275 - test-linux64/debug-marionette-headless-e10s MnH
   272 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
   267 - test-linux64/debug-marionette-e10s Mn
   172 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
   172 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
   132 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
    96 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
    89 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
    84 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
    52 - test-linux64/debug-mochitest-chrome-sw-3 c3
    52 - test-linux64/debug-mochitest-chrome-3 c3
    51 - test-linux64/debug-mochitest-plain-headless-sw-e10s-15 h15
    31 - test-linux64/debug-mochitest-chrome-sw-2 c2
    31 - test-linux64/debug-mochitest-chrome-2 c2
    30 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
    30 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
    28 - test-linux64/debug-mochitest-sw-e10s-15 15
    27 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
    27 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
    24 - test-linux64/debug-mochitest-e10s-15 15
    19 - test-linux64/debug-mochitest-sw-e10s-14 14
    19 - test-linux64/debug-mochitest-e10s-14 14
    16 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
    16 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
    12 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
    11 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
    11 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
    10 - test-linux64/debug-telemetry-tests-client-e10s c
     9 - test-linux64/debug-mochitest-devtools-chrome-e10s-13 dt13
     9 - test-linux64/debug-mochitest-clipboard-sw-e10s cl
     9 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-13 dt13
     9 - test-linux64/debug-mochitest-clipboard-e10s cl
     8 - test-linux64/debug-mochitest-chrome-sw-1 c1
     8 - test-linux64/debug-mochitest-chrome-1 c1
     8 - test-linux64/debug-crashtest-sw-e10s C
     8 - test-linux64/debug-crashtest-e10s C
     7 - test-linux64/debug-mochitest-a11y-sw a11y
     7 - test-linux64/debug-mochitest-a11y a11y
     6 - test-linux64/debug-mochitest-plain-headless-sw-e10s-4 h4
     6 - test-linux64/debug-mochitest-sw-e10s-4 4
     6 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
     6 - test-linux64/debug-mochitest-e10s-4 4
     6 - test-linux64/debug-mochitest-plain-headless-sw-e10s-12 h12
     5 - test-linux64/debug-mochitest-e10s-9 9
     5 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
     5 - test-linux64/debug-mochitest-sw-e10s-9 9
     5 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
     5 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
     5 - test-linux64/debug-mochitest-plain-headless-sw-e10s-9 h9
     4 - test-linux64/debug-mochitest-e10s-2 2
     4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
     4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-14 dt14
     4 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
     4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
     4 - test-linux64/debug-mochitest-devtools-chrome-e10s-14 dt14
     4 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
     4 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
     4 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
     4 - test-linux64/debug-mochitest-plain-headless-sw-e10s-2 h2
     4 - test-linux64/debug-mochitest-sw-e10s-2 2
     4 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
     2 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
     2 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
     1 - test-linux64/debug-mochitest-e10s-8 8
     1 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
     1 - test-linux64/debug-reftest-e10s-2 R2
     1 - test-linux64/debug-mochitest-plain-headless-sw-e10s-8 h8
     1 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
     1 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
     1 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
     1 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
     1 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
     1 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
     1 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
     1 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
     1 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
     1 - test-linux64/debug-mochitest-sw-e10s-8 8
     1 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
     1 - test-linux64/debug-reftest-sw-e10s-2 R2

It shows up in 954 tests. A few of the most prevalent:

  3196 - [e10s] browser/components/preferences/in-content/tests/browser_spotlight.js
  1908 - [e10s] browser/components/preferences/in-content/tests/browser_cookies_exceptions.js
  1496 - [e10s] browser/components/preferences/in-content/tests/browser_extension_controlled.js
  1364 - [e10s] browser/components/enterprisepolicies/tests/browser/browser_policy_set_homepage.js
  1326 - [e10s] browser/components/preferences/in-content/tests/browser_warning_permanent_private_browsing.js
  1292 - [e10s] browser/components/preferences/in-content/tests/browser_password_management.js
  1190 - [e10s] browser/components/preferences/in-content/tests/browser_search_within_preferences_1.js
  1134 - [e10s] browser/components/enterprisepolicies/tests/browser/browser_policy_websitefilter.js
  1122 - [e10s] browser/components/preferences/in-content/tests/browser_contentblocking.js
  1054 - [e10s] browser/components/preferences/in-content/tests/browser_bug1020245_openPreferences_to_paneContent.js

54716 WARNING: NS_ENSURE_SUCCESS(mStatus, mStatus) failed with result 0x804B000A: file obj-firefox/dist/include/nsIURIMutator.h, line 622

This warning [2] shows up in the following test suites:

 12509 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
 12493 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
  3339 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
  2708 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
  2013 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
  1457 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
  1334 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
  1299 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
  1274 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   880 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
   859 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
   824 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
   808 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
   756 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
   754 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
   748 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
   722 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
   722 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
   652 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
   650 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
   607 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
   607 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
   602 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
   504 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
   488 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
   472 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
   470 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
   436 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
   382 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
   342 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
   292 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
   284 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
   275 - test-linux64/debug-marionette-headless-e10s MnH
   272 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
   267 - test-linux64/debug-marionette-e10s Mn
   172 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
   172 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
   132 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
   100 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
   100 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
    96 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
    89 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
    84 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
    51 - test-linux64/debug-mochitest-plain-headless-sw-e10s-15 h15
    49 - test-linux64/debug-mochitest-chrome-sw-3 c3
    49 - test-linux64/debug-mochitest-chrome-3 c3
    28 - test-linux64/debug-mochitest-sw-e10s-15 15
    27 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
    27 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
    24 - test-linux64/debug-mochitest-e10s-15 15
    20 - test-linux64/debug-mochitest-sw-e10s-14 14
    20 - test-linux64/debug-mochitest-e10s-14 14
    16 - test-linux64/debug-mochitest-chrome-sw-2 c2
    16 - test-linux64/debug-mochitest-chrome-2 c2
    16 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
    16 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
    13 - test-linux64/debug-mochitest-sw-e10s-10 10
    13 - test-linux64/debug-mochitest-e10s-10 10
    13 - test-linux64/debug-mochitest-plain-headless-sw-e10s-10 h10
    13 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
    12 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
    11 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
    11 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
    10 - test-linux64/debug-telemetry-tests-client-e10s c
     9 - test-linux64/debug-mochitest-devtools-chrome-e10s-13 dt13
     9 - test-linux64/debug-mochitest-clipboard-sw-e10s cl
     9 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-13 dt13
     9 - test-linux64/debug-mochitest-clipboard-e10s cl
     8 - test-linux64/debug-mochitest-chrome-sw-1 c1
     8 - test-linux64/debug-mochitest-chrome-1 c1
     7 - test-linux64/debug-mochitest-a11y-sw a11y
     7 - test-linux64/debug-mochitest-a11y a11y
     7 - test-linux64/debug-crashtest-sw-e10s C
     7 - test-linux64/debug-crashtest-e10s C
     6 - test-linux64/debug-mochitest-plain-headless-sw-e10s-12 h12
     5 - test-linux64/debug-mochitest-e10s-9 9
     5 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
     5 - test-linux64/debug-mochitest-sw-e10s-9 9
     5 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
     5 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
     5 - test-linux64/debug-mochitest-plain-headless-sw-e10s-9 h9
     4 - test-linux64/debug-mochitest-e10s-2 2
     4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
     4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-14 dt14
     4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
     4 - test-linux64/debug-mochitest-devtools-chrome-e10s-14 dt14
     4 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
     4 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
     4 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
     4 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
     4 - test-linux64/debug-mochitest-plain-headless-sw-e10s-2 h2
     4 - test-linux64/debug-mochitest-sw-e10s-2 2
     4 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
     2 - test-linux64/debug-mochitest-e10s-8 8
     2 - test-linux64/debug-mochitest-plain-headless-sw-e10s-8 h8
     2 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
     2 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
     2 - test-linux64/debug-mochitest-sw-e10s-8 8
     2 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
     1 - test-linux64/debug-mochitest-plain-headless-sw-e10s-14 h14
     1 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
     1 - test-linux64/debug-reftest-e10s-2 R2
     1 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
     1 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
     1 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
     1 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
     1 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
     1 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
     1 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
     1 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
     1 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
     1 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
     1 - test-linux64/debug-reftest-sw-e10s-2 R2

It shows up in 952 tests. A few of the most prevalent:

  3196 - [e10s] browser/components/preferences/in-content/tests/browser_spotlight.js
  1908 - [e10s] browser/components/preferences/in-content/tests/browser_cookies_exceptions.js
  1496 - [e10s] browser/components/preferences/in-content/tests/browser_extension_controlled.js
  1364 - [e10s] browser/components/enterprisepolicies/tests/browser/browser_policy_set_homepage.js
  1326 - [e10s] browser/components/preferences/in-content/tests/browser_warning_permanent_private_browsing.js
  1292 - [e10s] browser/components/preferences/in-content/tests/browser_password_management.js
  1190 - [e10s] browser/components/preferences/in-content/tests/browser_search_within_preferences_1.js
  1134 - [e10s] browser/components/enterprisepolicies/tests/browser/browser_policy_websitefilter.js
  1122 - [e10s] browser/components/preferences/in-content/tests/browser_contentblocking.js
  1054 - [e10s] browser/components/preferences/in-content/tests/browser_bug1020245_openPreferences_to_paneContent.js

[1] https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/nsIURIMutator.h#472
[2] https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/nsIURIMutator.h#622

Hi,
The warnings were produced during Thunderbird test run (|make mozmill| test suite) that uses FULL DEBUG version fo TB.
I filed the bugzilla as follows:
Bug 1539997
NS_ERROR_MALFORMED_URI errors seen during |make mozmill| test of FULL DEBUG version of TB

From https://bugzilla.mozilla.org/show_bug.cgi?id=1539997#c0

Now, I dumped the value of aSpec that is passed to SetSpec function that returned error.

I found that the aSpec was of the following forms when the errors occurred.
(Number at the beginning of the line is the frequency of appearances.)

Now I figure we have incorrect URLs indeed.

Obviously, the proper URL form is not given (protocol and host parts part are missing).
In one case, the protocol part "moz-icon:" prefix probably is not recognized by M-C code.

40 {debug} SetSpec failed : aSpec=branding/brand.ftl
20 {debug} SetSpec failed : aSpec=messenger/aboutSupportMail.ftl
16 {debug} SetSpec failed : aSpec=messenger/preferences/fonts.ftl
16 {debug} SetSpec failed : aSpec=messenger/preferences/languages.ftl
16 {debug} SetSpec failed : aSpec=messenger/preferences/preferences.ftl
3 {debug} SetSpec failed : aSpec=moz-icon:http://www.mozilla.org/
4 {debug} SetSpec failed : aSpec=toolkit/about/aboutAddons.ftl
20 {debug} SetSpec failed : aSpec=toolkit/about/aboutSupport.ftl
20 {debug} SetSpec failed : aSpec=toolkit/global/resetProfile.ftl

I suspect there was a reason to print the warning when an error occurred.
I assume that the file path spec ought to have been a proper URI format, but the above were not
in the expected code.

Would it not be better to fix the caller to pass proper URI/URL format?

Just curious.

TIA

Assignee: nobody → erahm
Status: NEW → ASSIGNED
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f551c59554b5 Remove more verbose nsIURIMutator warnings. r=valentin

https://hg.mozilla.org/mozilla-central/rev/f551c59554b5

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: