1540457 - Remove Javascript Array generics in Thunderbird

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #1322124 +++

From bug 1222547 comment 0:

Array generics are non-standard SpiderMonkey extension and they should be removed.

• Array.concat
• Array.every
• Array.filter
• Array.forEach
• Array.indexOf
• Array.join
• Array.lastIndexOf
• Array.map
• Array.pop
• Array.push
• Array.reduce
• Array.reduceRight
• Array.reverse
• Array.shift
• Array.slice
• Array.some
• Array.sort
• Array.splice
• Array.unshift

Comment 1

[:aceman]

Attachment: 1540457.patch

A few remaining users after bug 1322124.
Changes done using patterns from https://hg.mozilla.org/comm-central/rev/0459647f3dc7 .

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8f95d4511c6afad9eb62e64e4105d7e047568d1e

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9054735 [details] [diff] [review]
1540457.patch

Review of attachment 9054735 [details] [diff] [review]:
-----------------------------------------------------------------

::: common/src/customizeToolbar.js
@@ +197,5 @@
>   * Wraps all items in all customizable toolbars in a toolbox.
>   */
>  function wrapToolbarItems() {
>    forEachCustomizableToolbar(function(toolbar) {
> +    Array.from(toolbar.childNodes).forEach(function(item) {

I think for (let item of toolbar.childNodes) would be more elegant

@@ +360,5 @@
>    aItem.removeAttribute("observes");
>    aItem.removeAttribute("type");
>    aItem.removeAttribute("width");
>  
> +  Array.from(aWrapper.querySelectorAll("[disabled]")).forEach(function(aNode) {

querSelectorAll(....).forEach works

::: mail/base/content/msgMail3PaneWindow.js
@@ +1956,5 @@
>    },
>  
>    _sizePlaceholder(type, width) {
> +    Array.from(document.querySelectorAll(".titlebar-placeholder[type='" + type + "']")).forEach(
> +               function(node) { node.style.width = width + "px"; });

just use querySelectorAll(.....).forEach

::: mail/base/modules/GlobalPopupNotifications.jsm
@@ +1266,5 @@
>      }
>  
>      let notifications = this._getNotificationsForBrowser(browser);
>      // Mark notifications as dismissed and call dismissal callbacks
> +    Array.from(this.panel.children).forEach(function(nEl) {

for (let nEl of this.panel.children)

Comment 3

[:aceman]

Attachment: 1540457.patch v2

Nice simplifications, thanks.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0b15ea2e74f514e3369f758c20895625d59f4ab3

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9054776 [details] [diff] [review]
1540457.patch v2

Review of attachment 9054776 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM thx! r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ff36478a185
remove remaining Array generics in Thunderbird. r=mkmelin DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

What about:
JavaScript warning: chrome://global/content/bindings/tabbox.xml, line 258: Array.indexOf is deprecated; use Array.prototype.indexOf instead

Comment 7

[:aceman]

I would kill that if .indexOf() is in our code, but that looks like m-c? They still have to sweep their stuff.

Comment 8

[Jorg K (CEST = GMT+2)]

Sorry, "global", yes, M-C.