1540529 - WebExtensions' option panel in toolbar overflow menu does not have a border

Status: NEW

(WebExtensions :: Frontend, defect, P5)

Description

[Fanolian]

Attachment: Overflow border missing

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0
Build ID: 20190331090052

Steps to reproduce

1. Set Nightly theme to Dark, and optionally density to compact.
2. Install any WebExtension that has a toolbar icon and leads to an option panel, e.g. Stylus.
3. Drag the extension icon into overflow menu.
4. Click on the icon.

Actual result
Dark border for arrow panel is not applied to the extension's option popup. (Please see the attached screenshot.)

Note
This should happen in all densities but most noticeable for compact since there is a gap between toolbar and the arrow panel.

Comment 1

[Fanolian]

Though this should be regressed by bug 1451947 according to Mozregression, the issue is reproducible in both light and dark theme.

Last good Nightly: 2018-04-08
First bad Nightly: 2018-04-09
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4bc6b2401738b78fd47127a4c716bb9178e1a09&tochange=83de58ddda2057f1cb949537f6b111e3b115ea3d

Further bisection: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=88657b4a0dd803dff57d82ee164fb549286d31b5&tochange=93ad00eae5749e9324484d979a078a045cb875ef

Comment 2

[Dão Gottwald [:dao]]

(In reply to Fanolian from comment #1)

Though this should be regressed by bug 1451947 according to Mozregression, the issue is reproducible in both light and dark theme.

Yeah, this doesn't seem to make much sense. ntim, any ideas?

Comment 3

[Tim Nguyen :ntim]

Can you please post a screenshot of how it used to look like before ?

Comment 4

[Tim Nguyen :ntim]

I found this code which is responsible for the problem: https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/browser/components/extensions/ExtensionPopups.jsm#384

but bug 1451947 doesn't make sense as regression range.

Comment 5

[Fanolian]

Attachment: 2018-04-08 no borders.png

Revisiting this bug, I think I made a mistake before.

In the last good Nightly (2018-04-08), there was no borders whatsoever for the arrow panels in the overflow menu, as seen in this attached screenshot.

Bug 1449933, which was fixed right before bug 1451947, should be a more appropriate candidate for this regression. Bug 1453803, according to comment 4, is a regression to bug 1449933 too.

I cannot confirm the regression however since Mozregression cannot bisect past Nightly builds for me right now. The mozilla-central regression range in comment 1 still applies.

Comment 6

[Tim Nguyen :ntim]

Jared, can you please look into this ?

https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/browser/components/extensions/ExtensionPopups.jsm#382-385

I'm asking this since you looked at bug 1453803 last :)

Comment 7

[David Durst [:ddurst]]

It's not clear to me what about this is Web Extensions. Jaws, can you clarify?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

I don't have the time to look in to this. @David, this panel is used by Web Extensions to display their own content in a panel, it's a special implementation of our toolbar button arrow panel.

Comment 9

[Miruna Curtean]

A mozzregression was performed and this issue could be reproduced, as mentioned in comment 1, starting with the first bad Nightly (2018-04-09).
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ee6283795f41d97faeaccbe8bd051a36bbe30c64&tochange=83de58ddda2057f1cb949537f6b111e3b115ea3d
Last known good version was:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4bc6b2401738b78fd47127a4c716bb9178e1a09&tochange=83de58ddda2057f1cb949537f6b111e3b115ea3d
Version: 61.0a1 (20180408220126)
Also reproduced in latest Nightly 71.0a1 (20190930095343), Beta 70.0b10 (20190926005616) and Release 69.0.1 (20190917135527) builds on Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.