1540534 - Moving the Search Bar to the menu bar resets option "Add search bar in toolbar"

Status: NEW

(Firefox :: Settings UI, defect, P3)

Description

[Irene Johnson]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 Firefox/52.0

Steps to reproduce:

Hello.

When you move the Search Bar to the menu bar, the setting "Add search bar in toolbar" is not saved and is reset to value "Use the address bar for search and navigation".

Steps to reproduce:

1. In the setting tab select option "Add search bar in toolbar". Close the setting tab.
2. Begin customize user interface. Move the Search Bar to the menu bar.
3. Again open the settings.

Mozillians, have you stopped testing your crafts?

Thanks.

Actual results:

The setting "Use the address bar for search and navigation" is set.

Expected results:

After moving the Search Bar to the menu bar, the option "Add search bar in toolbar" must be enabled.

Comment 1

[Gingerbread Man]

:standard8 since you implemented bug 1393437 maybe you'd like to take a look.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Looks like we're only considering the search bar as being in the toolbars if it's in the nav-bar:

https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/browser/components/customizableui/SearchWidgetTracker.jsm#73-76

I suppose we could relax that condition, and have the preference reflect that the search bar is in any of the toolbars, and not just the nav-bar. What do you think, Standard8?

Comment 3

[Mark Banner (:standard8)]

I think that would probably work. As far as I know we're not using the preference for any experiments at the moment. The prefs UI that I added was added after the preference was added. I suspect no-one thought about the customising onto other bars case.

Comment 4

[Mark Banner (:standard8)]

I just happened across bug 1396562 that might also be relevant here.