1540694 - DEBUG_DEVTOOLS_ALLOCATIONS is broken since DevTools shared the system principal compartment

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Bug 1517210 broke DEBUG_DEVTOOLS_ALLOCATIONS completly. It throws as it creates its Debugger instance in the same compartment than DevTools.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1540694 - Remove unecessary import-globals-from.

Now that there is a shared head.js, the import-globals-from is done from there.

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1540694 - Fix DEBUG_DEVTOOLS_ALLOCATIONS now that DevTools share the unique system compartment.

In bug 1517210, DevTools started sharing the same compartment than JSMs.
So we can no longer use a Debugger instance bound to jsdebugger.jsm as it
would run in the same compartment than DevTools code we want to inspect
from the allocation tracker.
Instead, we instantiate the Debugger from a custom Sandbox loaded
in a unique and distinct compartment.

Depends on D26077

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1540694 - Removed scopedCuImport usages.

ChromeUtils.import no longer pollute the global scope,
so we can switch to it and remove this ancient helper.

Depends on D26078

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb332aeab405
Remove unecessary import-globals-from. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/3ce71471f486
Fix DEBUG_DEVTOOLS_ALLOCATIONS now that DevTools share the unique system compartment. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/0c5e505e3799
Removed scopedCuImport usages. r=jdescottes

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bb332aeab405
https://hg.mozilla.org/mozilla-central/rev/3ce71471f486
https://hg.mozilla.org/mozilla-central/rev/0c5e505e3799