1540733 - Avoid re-using the IPCBlobInputStreamChild objects when migrating

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

Migrating this object between threads currently, and thus using the same object for multiple IPC channels, violates some of the invariants expected by the patch in bug 1540731.

Clearing the manager property and re-using one of these actors should not be done. Instead, this patch could be fixed by creating a new set of actors, and rewriting all IPCBlobInputStream objects to reference it when performing a migration.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1540733 - Create a new IPCBlobInputStreamChild actor when migrating,

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7cbe0438433
Create a new IPCBlobInputStreamChild actor when migrating, r=baku

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset a7cbe0438433 (bug 1540733) for causing browser_ipcBlob_temporary.js and test_wasm_recompile.js to perma fail

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a7cbe043843340945476d44fd59d8b015b98480d

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=e95b995fc086ba80fb30791901e634374d33eacf&selectedJob=241261265&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s-7%2Cm%28bc7%29

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=e95b995fc086ba80fb30791901e634374d33eacf&selectedJob=241259211&searchStr=windows%2C10%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows10-64%2Fdebug-xpcshell-e10s%2Cx%28x%29

backout: https://hg.mozilla.org/integration/autoland/rev/e3308b44faa7ea386242cc98ed4603435d40713b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6de795fcf1fa
Create a new IPCBlobInputStreamChild actor when migrating, r=baku

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/6de795fcf1fa