1540731 - Have IPC code hold a reference to keep the actor alive

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

This would add IPCAddRef and IPCRelease methods which control when the DeallocPProtocol method is called, and also introduce an IPCRefPtr<T> type which is used internally to manage this IPC reference count. These counts are not intended to be used outside of IPC, but rather as a temporary solution until bug 1509143 is able to be fully implemented.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1540731 - WIP

This is an initial version of the patch for this bug, however it doesn't
successfully pass browser startup. Unfortunately, currently the browser will
crash when attempting to migrate an IPC blob actor.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1540731 - Part 1: Manage actor object lifecycles within IPC,

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy,

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1540731 - Part 3: Keep actors alive when calling handler methods on them,

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1540731 - Part 3: Stop releasing actors within ActorDestroy,

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d30842e4cfea
Part 1: Manage actor object lifecycles within IPC, r=froydnj
https://hg.mozilla.org/integration/autoland/rev/89b214d41e50
Part 2: Move toplevel actors to override ActorDestroy, r=froydnj
https://hg.mozilla.org/integration/autoland/rev/11450b71e95e
Part 3: Stop releasing actors within ActorDestroy, r=mayhemer

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d30842e4cfea
https://hg.mozilla.org/mozilla-central/rev/89b214d41e50
https://hg.mozilla.org/mozilla-central/rev/11450b71e95e