1540982 - Upgrade to ESLint 6.2.0 or later (BigInt support)

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Description

[Andy Wingo [:wingo]]

Bug 1456569 includes some self-hosted JS that works on bigint values. Bigints are a new kind of primitive value and thus have their own typeof.

Unfortunately the patch for bug 1456569 was backed out because the linter didn't think that typeof x == 'bigint' was a valid comparison: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237483600&repo=autoland&lineNumber=281

The linter needs updating.

Comment 1

[Andy Wingo [:wingo]]

Unblocking bug because // eslint-disable workarounds are available.

Comment 2

[Mark Banner (:standard8)]

valid-typeof is a built-in ESLint rule. According to ESLint's documentation, ESLint only officially supports the latest standard. As BigInt is stage 3 we're not going to get this until it hits stage 4 / completion.

As mentioned in comment 1, using // eslint-disable-next-line valid-typeof or equivalent is the easiest thing to do for now, and we'll update once it gets to stage 4.

Comment 3

[Andy Wingo [:wingo]]

Just FYI, the only thing remaining for bigint to make stage 4 is shipping in SM, so I think it's reasonable for SM to make changes that assume bigint is stage 4 already. Good that there are workarounds though.

Comment 4

[Mark Banner (:standard8)]

Good news is that ESLint 6.2.0 is out which has support for BigInt, and dynamic imports. Bad news is that there's a regression when used with babel-eslint that currently stops us from upgrading to it.

I'm keeping an active watch, once it gets resolved I'll do the upgrade.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1540982 - Upgrade to ESLint 6.2.2 and switch to ECMA version 11 (BigInt support, Dynamic imports). r?Mossop

Comment 6

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed3b97953e35963ea23f09445e0afe12ca56395b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/639ee379247d
Upgrade to ESLint 6.2.2 and switch to ECMA version 11 (BigInt support, Dynamic imports). r=mossop

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/639ee379247d