Closed
Bug 1541006
Opened 6 years ago
Closed 6 years ago
Remove single use overlays from compose window
Categories
(SeaMonkey :: MailNews: Composition, enhancement)
SeaMonkey
MailNews: Composition
Tracking
(seamonkey2.53 affected, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.65
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(2 files, 2 obsolete files)
|
12.85 KB,
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
15.75 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
Currently addressingWidgetOverlay.xul and mailComposeExtrasOverlay.xul are only being used by messengercompose.xul so could be removed/folded into that file.
Attachment #9055096 -
Flags: review?(frgrahl)
For esr-60, patch keeps addressingWidgetOverlay.dtd so there are no string changes.
Attachment #9055099 -
Flags: review?(frgrahl)
Attachment #9055099 -
Flags: approval-comm-esr60?
On top of current patch queue
Attachment #9055101 -
Flags: review?(frgrahl)
We don't want to remove any l10n files / entities at the moment.
Attachment #9055096 -
Attachment is obsolete: true
Attachment #9055096 -
Flags: review?(frgrahl)
Attachment #9055104 -
Flags: review?(frgrahl)
Attachment #9055104 -
Attachment description: Flatten compose overlays without l10n file removal → Flatten compose overlays without l10n file removal for c-c
Attachment #9055099 -
Attachment description: Flatten compose overlays without l10n changes → Flatten compose overlays without l10n changes for esr60
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9055104 [details] [diff] [review]
Flatten compose overlays without l10n file removal for c-c
2.53 tested.
If we put the patch into esr60 we could probably remove the l10n there too but better be safe and use the old translations for 60.
Attachment #9055104 -
Flags: review?(frgrahl) → review+
|
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9055099 [details] [diff] [review]
Flatten compose overlays without l10n changes for esr60
suite/mailnews/components/compose/content/mailComposeExtrasOverlay.xul was added in Bug 161226. Looks pretty dead right now. Not sure if we can remove some other parts from this bug. Tree changed a lot.
Attachment #9055099 -
Flags: review?(frgrahl)
Attachment #9055099 -
Flags: review+
Attachment #9055099 -
Flags: approval-comm-esr60?
Attachment #9055099 -
Flags: approval-comm-esr60+
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9055101 [details] [diff] [review]
Flatten compose overlays without l10n changes for 2.53
The unofficial 2.53 has a wip patch for a delete button applied. I already rebased in my queue for testing. Basically the esr60 patch can be used for it.
Attachment #9055101 -
Attachment is obsolete: true
Attachment #9055101 -
Flags: review?(frgrahl)
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0696198c7fa8
Remove single use overlays from compose window. r=frg
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•6 years ago
|
||
Type: defect → enhancement
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
Target Milestone: --- → seamonkey2.65
You need to log in
before you can comment on or make changes to this bug.
Description
•