1541031 - Creating a new calendar event and choosing the New Event time with one mouse click no longer works

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Arthur K. (he/him)]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

In testing 67.0b1 build2, I attempted to create a new calendar event.

Actual results:

In 66.0b3, I would create a New Event and select a time (for example, 9AM). I could click on [9] then click out of the hour/minute choices area and it would accept my choice of 9AM. Now, it explicitly requires clicking [9] and [:00] minutes before accepting 9AM as the requested time.

Expected results:

Because a New Event defaults to using :00 minutes, I should have been able to click on [9] AM, click outside after clicking on [9] and it should accept the time as 9AM as was the behavior in 66.0b3 (and all previous TB versions for that matter).

Comment 1

[WaltS48 [:walts48]]

Double clicking the hour sets the time. But it did work the way you describe in TB 66.0b3. I usually set start times by typing in a 24hr time like 0900 or 1530. Probably why I didn't notice this in release candidate testing.

This is what I found testing 67.0a1 builds.

BuildID: 20190228090701 Built from https://hg.mozilla.org/comm-central/rev/d7609d079bc3f6f3a8ce94e9d6285216986edecd No date fields to work with in this build.

All previous builds had fields but the drop down arrows didn't work.

The first build I found with this and bug 1541026 is 67.0a1 BuildID: 20190301092936 Built from https://hg.mozilla.org/comm-central/rev/e854574aae9f63ce8a6138029dc511ba1fbe21c0

It is also in the current 68.0a1.

Comment 2

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: 1541031-timepicker-click-outside-1.diff

This ought to do the trick. I've decided to store the current value in timepicker instead of in the grid, that was probably wrong anyway but it prevented setting the value of the timepicker to that of the grid.

Comment 3

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: 1541031-timepicker-click-outside-2.diff

This is better, it fires the change event from a more appropriate place, and also doesn't break a test.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b40a153f8a7b
Accept <timepicker> value when closing the popup by clicking outside it; r=Fallen