Open Bug 1541118 Opened 6 years ago Updated 5 years ago

Add link to treeherder try push in top right menu on a revision

Categories

(Conduit :: Phabricator, enhancement, P3)

Product:
Conduit
Component:
Phabricator
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: smacleod, Unassigned)

References

Details

(Keywords: conduit-triaged)

A try push will be created for every diff uploaded to Phabricator for review. We should expose a link to this push on treeherder to allow users to trigger more jobs.

Type: defect → enhancement

What are the default jobs such a try push triggers? Can this already be looked for manually on Treeherder?

Flags: needinfo?(smacleod)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

What are the default jobs such a try push triggers? Can this already be looked for manually on Treeherder?

I believe the default jobs will most likely be linting and various static analysis jobs (no builds or tests). These are not being triggered quite yet, testing is going on in dev before switching things on in production. When the try pushes exist exposing it will be a high priority.

Flags: needinfo?(smacleod)

Morphing this a bit to make it clear what we'll do here in addition to the way the link is currently exposed. Plan is to stick a link in the top right menu where "View stack in Lando" is.

Summary: Expose treeherder link to automatic try pushes to allow triggering new jobs → Add link to treeherder try push in top right menu on a revision

Link text bikeshedding: "Add new Try job", "Add new CI job"

"Add new Treeherder Try CI job running on Taskcluster"

  • "©Reviewbot - also powered by Taskcluster"

So would this entail essentially copying what https://github.com/mozilla-services/phabricator-extensions/blob/104d628f5ea6b2941d0de066a1f1639fe15ee4eb/extensions/src/lando/events/LandoLinkEventListener.php and changing it all to refer to the Treeherder link? Where does the Diff Detail > Build Status > Treeherder Jobs link get generated, and how would one access it from the side menu's code?

I wouldn't mind giving this a shot if I can be shown where/how to get access to the Treeherder link.

Also, one downside to using the pushes Reviewbot generates for code analysis for adding actual build/test jobs is that the push author is "reviewbot" and the commit authors are all rewritten to be "Pulselistener:". This makes it hard to track all of my try pushes, since I can't filter in Treeherder to just show pushes done by my hg.m.o accout

Any chance there's already a bug on file for making sure the automatic try pushes are correctly crediting the patch author?

(In reply to Wes Kocher (:KWierso) from comment #8)

Any chance there's already a bug on file for making sure the automatic try pushes are correctly crediting the patch author?

I don't think so, please fill one :)

You need to log in before you can comment on or make changes to this bug.