1466275 - Determine how try integration work with Phabricator and Lando

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement, P2)

Description

[Mark Côté [:mcote]]

We'll want to support landing revisions on Try before too long.  One way to roll this out incrementally is default to landing on the current tip of mozilla-central to start, then later add the ability to specify a parent.

Comment 1

[Kelsey Gilbert [:jgilbert]]

This is one of the main areas where Phabricator is deficient compared to MozReview for me.

Comment 2

[:glob ✱]

this has happened; please document the outcome :)

Comment 3

[Steven MacLeod [:smacleod]]

RelMan will be triggering a try build for every change in Phabricator (in order to run static analysis / linting). The plan now is to expose adding extra jobs to this try push (whether through sending users to treeherder, or some other mechanism) rather than giving Phabricator/Lando the ability to push to try itself.

Comment 4

[Rob Wu [:robwu]]

Where can I find documentation to find the try push for a given Phabricator revision?
Or if it hasn't been implemented yet, what are the bugs that track this feature?

I was following this bug, hoping to see that one day I can click on a button or link in Phabricator to start a try job (particularly for revision that I did not author, i.e. from external contributors). With try syntax, and/or via the Treeherder UI as documented at https://wiki.mozilla.org/ReleaseEngineering/TryServer#Scheduling_jobs_with_Treeherder

Comment 5

[Steven MacLeod [:smacleod]]

(In reply to Rob Wu [:robwu] from comment #4)

Where can I find documentation to find the try push for a given Phabricator revision?
Or if it hasn't been implemented yet, what are the bugs that track this feature?

I have filed Bug 1541118 to track exposing the treeherder link. This try push doesn't exist yet when it does the work to expose it will be handled there.

...or via the Treeherder UI as documented at https://wiki.mozilla.org/ReleaseEngineering/TryServer#Scheduling_jobs_with_Treeherder

This will be the initial mechanism (and only mechanism, if it proves sufficient).

Comment 6

[Ed Lee :Mardak]

(In reply to Rob Wu [:robwu] from comment #4)

With try syntax

Looks like treeherder allows adding jobs with something like fuzzy once the try push exists. Although supporting try syntax to avoid needing to manually select sets of jobs would be nice. E.g., -p win64,macosx64 -u mochitests,xpcshell seems to require a lot of clicks via treeherder, so something more streamlined (via Phabricator ??) could be good.

Comment 7

[Marco Castelluccio [:marco]]

At some point we could add support for using coverage data to automatically choose the jobs to run (depending on bug 1507108).