1541508 - Expose nsIEnvironment through Services.env

Status: RESOLVED FIXED

(Core :: XPCOM, task, P5)

Description

[Brian Grinstead [:bgrins]]

This is used in a bunch of places that could be simplified if we moved this into Services: https://searchfox.org/mozilla-central/search?q=nsIEnvironment&path=.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Moving to "Core :: XPCOM" from to consider if this may be worth doing.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

IIRC all you'd need to do for this is to add js_name and interfaces fields to the static component registration: https://searchfox.org/mozilla-central/rev/685203e4bc211073284f3c36f7f3d34f0953bb9c/xpcom/threads/components.conf#8-13, if someone is interested in doing this cleanup.

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Expose nsIEnvironment as Services.env r?#xpcom-reviewers

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in browser/ r?mossop

Depends on D160135

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in devtools/ r?nchevobbe

Depends on D160136

Comment 6

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in dom/ r?emilio

Depends on D160137

Comment 7

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in extensions/ r?#extension-reviewers

Depends on D160138

Comment 8

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in layout/ r?#layout-reviewers

Depends on D160139

Comment 9

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in memory/ r?mccr8

Depends on D160140

Comment 10

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in mobile/ r?#geckoview-reviewers

Depends on D160141

Comment 11

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in netwerk/ r?valentin

Depends on D160142

Comment 12

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in remote/ r?whimboo

Depends on D160143

Comment 13

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in security/ r?keeler

Depends on D160144

Comment 14

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in services/ r?markh

Depends on D160145

Comment 15

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in testing/ r?jmaher

Depends on D160146

Comment 16

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in toolkit/ r?Gijs

Depends on D160147

Comment 17

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in tools/ r?marco

Depends on D160149

Comment 18

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in uriloader/ r?nika

Depends on D160150

Comment 19

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in xpcom/ r?#xpcom-reviewers

Depends on D160151

Comment 20

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in gfx/ r?botond

Depends on D160152

Comment 21

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use Services.env in widget/ r?jmathies

Depends on D160153

Comment 22

[Florian Quèze [:florian]]

Thanks a lot for doing this nice cleanup!

Should this new Services.env be added to the list in https://searchfox.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-mozilla/lib/services.json to have eslint catch it when it should be used but is not? (apologies if you are already doing it and I missed it)

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1896eacb6f1
Expose nsIEnvironment as Services.env r=xpcom-reviewers,kmag
https://hg.mozilla.org/integration/autoland/rev/2c59d66f43e4
Use Services.env in browser/ r=mossop
https://hg.mozilla.org/integration/autoland/rev/e944e706a523
Use Services.env in devtools/ r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/44ccfeca7364
Use Services.env in dom/ r=emilio
https://hg.mozilla.org/integration/autoland/rev/c4374a351356
Use Services.env in extensions/ r=extension-reviewers,robwu
https://hg.mozilla.org/integration/autoland/rev/0bfc7dd85c62
Use Services.env in gfx/ r=botond
https://hg.mozilla.org/integration/autoland/rev/740010cb005c
Use Services.env in layout/ r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/8bd08a62a590
Use Services.env in memory/ r=mccr8
https://hg.mozilla.org/integration/autoland/rev/c1279c3d674c
Use Services.env in mobile/ r=geckoview-reviewers,m_kato
https://hg.mozilla.org/integration/autoland/rev/7d44f6e2644c
Use Services.env in netwerk/ r=valentin,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/2c599ee639c4
Use Services.env in remote/ r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/6098e2eb62ea
Use Services.env in security/ r=keeler
https://hg.mozilla.org/integration/autoland/rev/2e7db4aa8d4f
Use Services.env in services/ r=Gijs
https://hg.mozilla.org/integration/autoland/rev/fa40dded133e
Use Services.env in testing/ r=jmaher,perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/b3d8e92f50c2
Use Services.env in toolkit/ r=Gijs,application-update-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/6bb9360473f7
Use Services.env in tools/ r=marco
https://hg.mozilla.org/integration/autoland/rev/aa612a5e9ef7
Use Services.env in uriloader/ r=Gijs
https://hg.mozilla.org/integration/autoland/rev/0bf7514845db
Use Services.env in widget/ r=Gijs
https://hg.mozilla.org/integration/autoland/rev/08476fa2bc27
Use Services.env in xpcom/ r=xpcom-reviewers,kmag

Comment 24

[Cristian Tuns]

Backed out for causing xpcshell failures on test_notHeadlessByDefault.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | test_notHeadlessByDefault.js | xpcshell return code: 0

Lint failure log: https://treeherder.mozilla.org/logviewer?job_id=395186846&repo=autoland

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7c5da72773e
Expose nsIEnvironment as Services.env r=xpcom-reviewers,kmag
https://hg.mozilla.org/integration/autoland/rev/79044f07da6f
Use Services.env in browser/ r=mossop
https://hg.mozilla.org/integration/autoland/rev/13ab592d9fc7
Use Services.env in devtools/ r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/422102d31f7d
Use Services.env in dom/ r=emilio
https://hg.mozilla.org/integration/autoland/rev/f57eac075fbe
Use Services.env in extensions/ r=extension-reviewers,robwu
https://hg.mozilla.org/integration/autoland/rev/c52ce5a1b79d
Use Services.env in gfx/ r=botond
https://hg.mozilla.org/integration/autoland/rev/7a1f0febe1bc
Use Services.env in layout/ r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/a502617685ab
Use Services.env in memory/ r=mccr8
https://hg.mozilla.org/integration/autoland/rev/784c91d51e52
Use Services.env in mobile/ r=geckoview-reviewers,m_kato
https://hg.mozilla.org/integration/autoland/rev/8c8d647347e8
Use Services.env in netwerk/ r=valentin,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/4a9ca69a0d29
Use Services.env in remote/ r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/92fea1a71ea3
Use Services.env in security/ r=keeler
https://hg.mozilla.org/integration/autoland/rev/2fba28997d4b
Use Services.env in services/ r=markh,Gijs
https://hg.mozilla.org/integration/autoland/rev/cd17720763b6
Use Services.env in testing/ r=jmaher,perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/6c1df04495c1
Use Services.env in toolkit/ r=Gijs,application-update-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/193790f0eeab
Use Services.env in tools/ r=marco
https://hg.mozilla.org/integration/autoland/rev/d6a979c61480
Use Services.env in uriloader/ r=Gijs
https://hg.mozilla.org/integration/autoland/rev/576387596194
Use Services.env in widget/ r=Gijs
https://hg.mozilla.org/integration/autoland/rev/641e9a674452
Use Services.env in xpcom/ r=xpcom-reviewers,kmag

Comment 26

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use SpecialPowers.Services in helper_transform_end_on_keyboard_scroll.html

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af58a74ada19
Use SpecialPowers.Services in helper_transform_end_on_keyboard_scroll.html. CLOSED TREE

Comment 28

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1541508 - Use SpecialPowers.Cc in helper_transform_end_on_keyboard_scroll.html to avoid macOS test timeouts

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3bebb9a12f9
Use SpecialPowers.Cc in helper_transform_end_on_keyboard_scroll.html to avoid macOS test timeouts. CLOSED TREE

Comment 30

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f7c5da72773e
https://hg.mozilla.org/mozilla-central/rev/79044f07da6f
https://hg.mozilla.org/mozilla-central/rev/13ab592d9fc7
https://hg.mozilla.org/mozilla-central/rev/422102d31f7d
https://hg.mozilla.org/mozilla-central/rev/f57eac075fbe
https://hg.mozilla.org/mozilla-central/rev/c52ce5a1b79d
https://hg.mozilla.org/mozilla-central/rev/7a1f0febe1bc
https://hg.mozilla.org/mozilla-central/rev/a502617685ab
https://hg.mozilla.org/mozilla-central/rev/784c91d51e52
https://hg.mozilla.org/mozilla-central/rev/8c8d647347e8
https://hg.mozilla.org/mozilla-central/rev/4a9ca69a0d29
https://hg.mozilla.org/mozilla-central/rev/92fea1a71ea3
https://hg.mozilla.org/mozilla-central/rev/2fba28997d4b
https://hg.mozilla.org/mozilla-central/rev/cd17720763b6
https://hg.mozilla.org/mozilla-central/rev/6c1df04495c1
https://hg.mozilla.org/mozilla-central/rev/193790f0eeab
https://hg.mozilla.org/mozilla-central/rev/d6a979c61480
https://hg.mozilla.org/mozilla-central/rev/576387596194
https://hg.mozilla.org/mozilla-central/rev/641e9a674452
https://hg.mozilla.org/mozilla-central/rev/af58a74ada19
https://hg.mozilla.org/mozilla-central/rev/b3bebb9a12f9

Comment 31

[Geoff Lankow (:darktrojan)]

Attachment: Port Bug 1541508 - Expose nsIEnvironment through Services.env. r=mkmelin

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e5532f1e88ca
Port Bug 1541508 - Expose nsIEnvironment through Services.env. r=mkmelin DONTBUILD

Comment 33

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9b4bdd165db5
Port Bug 1541508 - Expose nsIEnvironment through Services.env. r=mkmelin