1802605 - Use SpecialPowers.Services.env in test_group_keyboard.html and helper_relative_scroll_smoothness.html

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Beth Rennie [:beth] (she/her)]

Bug 1541508 adds Services.env but trying to use it in helper_transform_end_on_keyboard_scroll.html causes test time outs on macOS due to a ReferenceError:

[task 2022-11-25T22:43:45.558Z] 22:43:45     INFO - GECKO(2465) | JavaScript error: http://mochi.test:8888/tests/gfx/layers/apz/test/mochitest/helper_relative_scroll_smoothness.html?input-type=native-key&scroll-method=scrollBy, line 124: ReferenceError: Services is not defined

(which is curious because the code is using SpecialPowers.Services)

Using SpecialPowers.Cc["@mozilla.org/process/environment;1"].getService(SpecialPowers.Ci.nsIEnvironment) still works but triggers a lint error, so a supression was added to the file.

The time outs did not occur when running the test on Windows -- SpecialPowers.Services was defined and works as expected.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Panning and Zooming' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Beth Rennie [:beth] (she/her)]

I was wrong. In my rush I didn't notice that there were two different tests that were changed to use Services.env from SpecialPowers.Cc. The other test does not run on Windows, which is why I could not reproduce.

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1802605 - Use SpecialPowers.Services.env in gfx tests r?botond

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4a229ed50c7
Use SpecialPowers.Services.env in gfx tests r=botond

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f4a229ed50c7