1541543 - Incorrect hardcoded icon colors in pocket menu (worse for dark theme)

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ed Lee :Mardak]

Attachment: new icons in dark theme

The svgs have hardcoded colors instead of using context.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4882

Comment 2

[Jessilyn Davis]

Hey Punam - is this something you can knock out this week before PTO next? (if not, we'll punt it to next week and someone can grab it if they can)

Comment 3

[Punam Dahiya [:pdahiya]]

(In reply to Jessilyn Davis from comment #2)

Hey Punam - is this something you can knock out this week before PTO next? (if not, we'll punt it to next week and someone can grab it if they can)

PR for this bug has landed in GitHub and should get fixed in nightly in next export. Thanks!

Comment 4

[Jessilyn Davis]

Amazing! Thank you, Punam!

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7a435211fa07

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190414214746) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the icons are respecting the browser's "Dark" theme colors.