Incorrect hardcoded icon colors in pocket menu (worse for dark theme)

VERIFIED FIXED in Firefox 68

Status

()

defect
P1
normal
VERIFIED FIXED
5 months ago
2 months ago

People

(Reporter: Mardak, Assigned: pdahiya)

Tracking

({github-merged})

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 verified)

Details

Attachments

(2 attachments)

The svgs have hardcoded colors instead of using context.

Summary: Incorrect icon colors in menu for dark theme → Incorrect hardcoded icon colors in pocket menu (worse for dark theme)
Assignee: nobody → pdahiya
Keywords: github-merged

Hey Punam - is this something you can knock out this week before PTO next? (if not, we'll punt it to next week and someone can grab it if they can)

Iteration: --- → 68.3 - Apr 15 - 28
Flags: needinfo?(pdahiya)
Priority: -- → P1

(In reply to Jessilyn Davis from comment #2)

Hey Punam - is this something you can knock out this week before PTO next? (if not, we'll punt it to next week and someone can grab it if they can)

PR for this bug has landed in GitHub and should get fixed in nightly in next export. Thanks!

Flags: needinfo?(pdahiya)

Amazing! Thank you, Punam!

Iteration: 68.3 - Apr 15 - 28 → 68.2 - Apr 1 - 14
Blocks: 1543756
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190414214746) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the icons are respecting the browser's "Dark" theme colors.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.