1527500 - [Context Menu] Implement Save to Pocket and bookmark menu option inside pocket new tab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Daniel Holbert [:dholbert]]

Quoting :morgan's tweet:

for some reason I can't save @pocket articles from the new tab page in @FirefoxNightly. Was this removed? (I used to see a little ellipses symbol in the upper right on mouse-over)
https://twitter.com/MorgynRae/status/1095462704267972609

I'm pretty sure this change was due to the recent switchover to the "Pocket new-tab" experience in bug 1512725.

--> Filing this bug on adding an easily-discoverable (or at least, not-harder-than-it-was-before) to save one of the suggested articles to pocket.

As mconley said in a response on Twitter, there is at least a "Save link to pocket" entry in the right-click context menu (as there is for all links), but we might want to make it extra-easy for these likely-to-be-pocketable articles.

Comment 1

[Daniel Holbert [:dholbert]]

(sorry, I meant to say "the recent switchover...in bug 1523703". The bug I linked & tagged this as blocking, bug 1512725, seems to be the metabug for this feature in general.)

Comment 2

[Ed Lee :Mardak]

The regular link context menu still has "Save Link to Pocket" even though the (...) menu is gone.

Edit: Oh sorry, this was in the original comment already responded.

Comment 3

[Punam Dahiya [:pdahiya]]

Marking this bug as duplicate of bug 1527642, as the menu shown against a story will have options to dismiss and save articles to pocket

Comment 5

[Punam Dahiya [:pdahiya]]

Reopening as per https://bugzilla.mozilla.org/show_bug.cgi?id=1527642#c6

Comment 6

[Punam Dahiya [:pdahiya]]

Scope of this bug is to implement 'Save to Pocket' menu option for Pocket New Tab. Once a story is Saved to Pocket, menu options should change to 'Archive in Pocket' and 'Delete from Pocket'. See https://bugzilla.mozilla.org/show_bug.cgi?id=1527642#c6

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4863

Comment 9

[Wolasi :wolasi]

Here's the Figma spec for reference by QA https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=70%3A6

Comment 10

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7a266c35cb30

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190404215521) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now the "Save to Pocket" and "Bookmark" options are displayed inside the "Pocket New Tab" menu according to the specs from the comment 9.