Open Bug 1541603 Opened 5 months ago Updated 6 days ago

MakeOrSetMinidumpPath shouldn't bother doing IO and just set the env var, leaving the crash reporter to create the minidumps folder if necessary

Categories

(Toolkit :: Crash Reporting, defect, P1)

defect

Tracking

()

ASSIGNED

People

(Reporter: Gijs, Assigned: mcheang)

References

(Blocks 2 open bugs)

Details

(Keywords: main-thread-io, perf, Whiteboard: [fxperf:p2] [fxperfsize:S])

Attachments

(1 file)

As in summary. The code adds insult to injury by doing an exists() check followed by a create() - but I think the correct solution is to just do this work in the crashreporter, and just update the env var when we have a profile without doing any IO.

Keywords: main-thread-io, perf
Whiteboard: [fxperf]
Whiteboard: [fxperf] → [fxperf:p2]

This looks fairly straightforward...

Whiteboard: [fxperf:p2] → [fxperf:p2] [fxperfsize:S]
Assignee: nobody → mcheang
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b59c9bfa328d
remove creation of minidumps folder on startup, create it lazily in crash reporter. r=gsvelto
Flags: needinfo?(mcheang)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16ee100ad0c9
Backed out changeset b59c9bfa328d for causing xpcshell failure in toolkit/crashreporter/test/unit_ipc/test_content_annotation.js CLOSED TREE

Mandy, it looks like the minidump & extra files are not being moved correctly in the test environment. You'll have to run the tests locally and see what's going on. The only difference between a normal run and a test run is that ShouldReport() will return false and the target minidump directory will be different. I find it odd that your change doesn't work under those conditions but we might have missed some corner-case that comes up in tests.

Status: NEW → ASSIGNED
Priority: -- → P1

Thanks Gabriele, I will take a look at why those tests are failing.

Flags: needinfo?(mcheang)

Adding bug 1546460, since we'll no longer be creating the minidump folder for brand new user profiles right at startup anymore.

Blocks: 1546460
You need to log in before you can comment on or make changes to this bug.