1831406 - We've been unintentionally skipping browser_startup_mainthreadio.js for 5 months

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1794715 added a rule to a mochitest-browser test manifest to not run browser_startup_mainthreadio.js on 32-bit Windows.

Unfortunately, a small typo caused that test to be skipped altogether (since os = win always evaluates to true, I believe).

We should revive this test, and (ugh) update the allow-list with any new IO that's snuck in since it's been disabled.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/jobs?repo=try&revision=fd628036452bb32c4db72130666c4bc6928f39a7

Comment 2

[:Gijs (he/him)]

😭

Filed bug 1831514 to prevent this structurally in the test manifest parser.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1794715

Comment 4

[:Gijs (he/him)]

Mike, do you have cycles to investigate this further and get this re-enabled? If not, let me know and I think I can take it...

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Yeah, sorry - been heads down on this device migration thing for the past few days and haven't yet had time to surface. If you have time to take this, please by all means!

Comment 6

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #5)

Yeah, sorry - been heads down on this device migration thing for the past few days and haven't yet had time to surface. If you have time to take this, please by all means!

NP, I can chase this some more.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1831406 - move NSS mainthread IO allowlist entries to before becoming idle instead of before handling user events in browser_startup_mainthreadio.js, r?mconley

Depends on D178062

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1831406 - add exception for ORB JS validator loading ld.so.conf to browser_startup_mainthreadio.js, r?mconley

Depends on D178063

Comment 9

[:Gijs (he/him)]

Attachment: Bug 1831406 - re-enable browser_startup_mainthreadio.js, r?mconley

Depends on D178064

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0385612c48c5
move NSS mainthread IO allowlist entries to before becoming idle instead of before handling user events in browser_startup_mainthreadio.js, r=mconley
https://hg.mozilla.org/integration/autoland/rev/3558266c434f
add exception for ORB JS validator loading ld.so.conf to browser_startup_mainthreadio.js, r=mconley
https://hg.mozilla.org/integration/autoland/rev/536375224eb1
re-enable browser_startup_mainthreadio.js, r=mconley

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1833104, Bug 1831406) for causing failures in browser_startup_mainthreadio.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=UZkdO2d6RXSlufYXYjJv7w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=536375224eb1c62bcff369c691ca5b2f1d959a56

Log: https://treeherder.mozilla.org/logviewer?job_id=415850103&repo=autoland&lineNumber=3734

Backout: https://hg.mozilla.org/integration/autoland/rev/69f226b3c41e8fe89cf6567ac2356cccfa19acfc

Comment 12

[:Gijs (he/him)]

Hrmpf, missed that there was an msix-specific failure.

I'm going to reland the patches minus the one enabling the test, to reduce noise...

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f20f53c755c
move NSS mainthread IO allowlist entries to before becoming idle instead of before handling user events in browser_startup_mainthreadio.js, r=mconley
https://hg.mozilla.org/integration/autoland/rev/b71496ed5bb1
add exception for ORB JS validator loading ld.so.conf to browser_startup_mainthreadio.js, r=mconley

Comment 14

[:Gijs (he/him)]

Attachment: Bug 1831406 - add exception for msix distribution.ini read, r?mconley

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0f20f53c755c
https://hg.mozilla.org/mozilla-central/rev/b71496ed5bb1

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d366ee04eb45
add exception for msix distribution.ini read, r=mconley
https://hg.mozilla.org/integration/autoland/rev/1b84db2f5f78
re-enable browser_startup_mainthreadio.js, r=mconley

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d366ee04eb45
https://hg.mozilla.org/mozilla-central/rev/1b84db2f5f78

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.