1541633 - Move sourcemap processing to be more closely tied to source actors to better align with dependencies

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[Logan Smyth [:loganfsmyth]]

SourceMaps are entirely per-source-actor since sourceMappingURL is per-source-actor. Having it be based on SourceID makes things more confusing.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541633 - Part 1: Move original ID generation into the source-map worker. r=jlast

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541633 - Part 2: Give workers a way to cleanly pass metadata about errors to callers. r=jlast

Depends on D42933

Comment 3

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541633 - Part 3: Reduce the amount of data passed to the source-map worker functions. r=jlast

Depends on D42934

Comment 4

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541633 - Part 4: Move sourceMapURL usage into centralized selectors. r=jlast

Depends on D42935

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541633 - Part 5: Move sourceMapURL field out of Source object. r=jlast

Depends on D42936

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de895ee6de42
Part 1: Move original ID generation into the source-map worker. r=jlast
https://hg.mozilla.org/integration/autoland/rev/a8378192e3b6
Part 2: Give workers a way to cleanly pass metadata about errors to callers. r=jlast
https://hg.mozilla.org/integration/autoland/rev/44ea34f63223
Part 3: Reduce the amount of data passed to the source-map worker functions. r=jlast
https://hg.mozilla.org/integration/autoland/rev/59019ae6bf3f
Part 4: Move sourceMapURL usage into centralized selectors. r=jlast
https://hg.mozilla.org/integration/autoland/rev/35fe7c48b49a
Part 5: Move sourceMapURL field out of Source object. r=jlast

Comment 7

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=35fe7c48b49a70c8d6b08a852d7edce6299dd38e&searchStr=devtools&selectedJob=262858551

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262858551&repo=autoland&lineNumber=4629
https://treeherder.mozilla.org/logviewer.html#?job_id=262857244&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/5c380cba7d7cc18bb7a95a9cc95095f5eca94dae

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5efa9d76fc9
Part 1: Move original ID generation into the source-map worker. r=jlast
https://hg.mozilla.org/integration/autoland/rev/48ab934cd025
Part 2: Give workers a way to cleanly pass metadata about errors to callers. r=jlast
https://hg.mozilla.org/integration/autoland/rev/cc36acbf92ad
Part 3: Reduce the amount of data passed to the source-map worker functions. r=jlast
https://hg.mozilla.org/integration/autoland/rev/3885329bda0d
Part 4: Move sourceMapURL usage into centralized selectors. r=jlast
https://hg.mozilla.org/integration/autoland/rev/6ad70843c2b3
Part 5: Move sourceMapURL field out of Source object. r=jlast

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b5efa9d76fc9
https://hg.mozilla.org/mozilla-central/rev/48ab934cd025
https://hg.mozilla.org/mozilla-central/rev/cc36acbf92ad
https://hg.mozilla.org/mozilla-central/rev/3885329bda0d
https://hg.mozilla.org/mozilla-central/rev/6ad70843c2b3