1541772 - Crash in [@ mozilla::dom::`anonymous namespace'::PrepareDatastoreOp::DatabaseWork]

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P3, critical)

Description

[Jan Varga [:janv]]

This bug is for crash report bp-747f53c0-d56e-4aae-8195-71dc40190404.

Top 10 frames of crashing thread:

0 xul.dll nsresult mozilla::dom::`anonymous namespace'::PrepareDatastoreOp::DatabaseWork dom/localstorage/ActorsParent.cpp:6330
1 xul.dll nsresult mozilla::dom::`anonymous namespace'::PrepareDatastoreOp::NestedRun dom/localstorage/ActorsParent.cpp:6660
2 xul.dll nsresult mozilla::dom::`anonymous namespace'::LSRequestBase::Run dom/localstorage/ActorsParent.cpp:5806
3 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1180
4 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:482
5 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:303
6 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
7 xul.dll static void nsThread::ThreadFunc xpcom/threads/nsThread.cpp:454
8 nss3.dll static void _PR_NativeRunThread nsprpub/pr/src/threads/combined/pruthr.c:397
9 nss3.dll unsigned int pr_root nsprpub/pr/src/md/windows/w95thred.c:137

Comment 1

[Julien Cristau [:jcristau]]

This started showing up again in nightly 20190519213707.
Crash reason MOZ_RELEASE_ASSERT(mUsage == 0)

Comment 2

[Jan Andre Ikenmeyer [:darkspirit]]

A Reddit user ran into this when opening Instagram: bp-7e81ae1c-095c-4506-b1fc-1d63b0190521
https://www.reddit.com/r/firefox/comments/brc28c/visiting_some_websites_crashes_firefox_nightly/

Comment 3

[[:philipp]]

this crash seems to continue with the signature from bug 1552756 in recent nightly builds - on 68.0b it's only hitting devedition users.

Comment 4

[Andrew Overholt [:overholt]]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #2)

A Reddit user ran into this when opening Instagram: bp-7e81ae1c-095c-4506-b1fc-1d63b0190521
https://www.reddit.com/r/firefox/comments/brc28c/visiting_some_websites_crashes_firefox_nightly/

Did you see this, janv?

Comment 5

[Jan Varga [:janv]]

No, but the assertion has been converted back to MOZ_ASSERT, so it shouldn't crash in optimized builds anymore.

Comment 6

[Robin]

(In reply to Jan Varga [:janv] from comment #5)

No, but the assertion has been converted back to MOZ_ASSERT, so it shouldn't crash in optimized builds anymore.

I'm the reddit user "Jan Andre Ikenmeyer" mentioned and it seems to be fixed for me now. Doesn't crash anymore.

Comment 7

[Jan Varga [:janv]]

Ok, but I landed the change only recently so it will take several hours to appear in a nightly build.

Comment 8

[Jan Varga [:janv]]

This is now fixed. See bug 1540401 comment 35.