1541910 - Quantumbar: popup should not have an inner border

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Mehmet]

Attachment: actual.png

Firefox Nightly 68.0a1 (2019-04-04) (64-Bit)
MacOS 10.14.4 - but probably OS=ALL_Desktop

STR:

1.) Enable Quantum Bar or be in the Experiment
2.) Type something into the Address Bar
3.) Take at a look at the borders of the Drop Down, especially at the top.

Actual: The Dropdown has an inner border on all sides.

Expected: No inner border.

The Drop Down border is now (after fixing issue 1538367) aligned again with the Toolbar border, but there is an inner border which makes the border look like 2px - which looks too bold. The old Drop Down border was only 1px which looked and matched perfectly aligned with the Toolbar and window border.

Thanks for listening.

Comment 1

[Mehmet]

Attachment: expected.png

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1541910 - Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cec029155339
Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cec029155339

Comment 5

[Mehmet]

Hello Dão,

unfortunately this change brings back bug 1538367 :(

I am using a Non-Retina MacBook Air.

Should I file a new report?

Thanks.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Mehmet from comment #5)

Hello Dão,

unfortunately this change brings back bug 1538367 :(

I am using a Non-Retina MacBook Air.

Should I file a new report?

Yep, thanks.

Comment 7

[Mehmet]

(In reply to Dão Gottwald [::dao] from comment #6)

(In reply to Mehmet from comment #5)

Hello Dão,

unfortunately this change brings back bug 1538367 :(

I am using a Non-Retina MacBook Air.

Should I file a new report?

Yep, thanks.

Done: Bug 1544030 :)