1538367 - QuantumBar: Dropdown has a 2px border on top - it should be only 1px to be aligned with the Toolbar Border

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Mehmet]

Attachment: screencast.mov

macOS 10.14.3
68.0a1 (2019-03-22) (64-Bit)
MacBook Air NonRetina

Steps to reproduce:
1.) Enable QuantumBar or be in the Experiment
2.) Type something into the Address Bar, so that the Drop Down appears
3.) Take a look at the top border of the Drop Down

Actual: The top border has 1px too much border, so that it is no longer aligned with the Toolbar border.

Expected: Drop Down Border should be aligned with the Toolbar Border, like in the actual AddressBar Drop Down.

Please find attached a screencast.

Thanks
Mehmet

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1538367 - Fix quantumbar popup's vertical position on Mac. r=Standard8,mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1f4e710ff8e
Fix quantumbar popup's vertical position on Mac. r=mak

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c1f4e710ff8e

Comment 4

[Mehmet]

Hello Dão,

thanks for fixing this. The Drop Down top border is now aligned with the Toolbar border, but the border is still 2px which makes the border look a bit too bold. The old Drop Down top border was only 1px which looked and matched perfectly aligned with the Toolbar border. Can you please take a look again? Thanks :)

Comment 5

[Mehmet]

Attachment: expected.png

• screenshot expected.

Comment 6

[Mehmet]

Attachment: actual.png

• screenshot actual

Comment 7

[Dão Gottwald [:dao]]

Could you please file a new bug on that? Thanks!

Comment 8

[Mehmet]

(In reply to Dão Gottwald [::dao] from comment #7)

Could you please file a new bug on that? Thanks!

Done: Bug 1541910. Thanks :)