Open Bug 1542026 Opened 6 years ago Updated 1 year ago

`browser.theme.reset()` applies broken version of default theme when in system dark mode

Categories

(WebExtensions :: Themes, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: ntim, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image Screenshot
No description provided.

STR:

  • Enable the default theme (if not already enabled)
  • Enable the system dark mode
  • Call browser.theme.reset()

In this case, before bug 1525762, it would reset to the non-dark default theme, but bug 1415267 requests to reset it to the currently enabled static theme (which would be the dark theme).

Summary: `browser.theme.reset()` applies broken version of default theme → `browser.theme.reset()` applies broken version of default theme in dark mode
Summary: `browser.theme.reset()` applies broken version of default theme in dark mode → `browser.theme.reset()` applies broken version of default theme when in system dark mode
Keywords: regression

You're saying it resets to the built-in dark theme? What's the broken part?

Flags: needinfo?(mdeboer)
See Also: → 1542044
Flags: needinfo?(mdeboer) → needinfo?(ntim.bugs)

(In reply to David Durst [:ddurst] from comment #2)

You're saying it resets to the built-in dark theme? What's the broken part?

The all white theme you see in attachment 9055968 [details] is what it resets to, instead of resetting to the either the built-in dark theme, either the default theme (depending on which behaviour we want).

Flags: needinfo?(ntim.bugs)

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mdeboer)
Flags: needinfo?(mdeboer)
Priority: -- → P2
Severity: normal → S3
Priority: P2 → P3
Has Regression Range: --- → yes
See Also: → 1774054
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: