Match star rating icons to AMO
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | verified |
People
(Reporter: mstriemer, Assigned: robwu, Mentored)
References
Details
Attachments
(2 files)
Bug1542262.png
The current star ratings for the HTML about:addons doesn't exactly match the AMO half stars. Figure out what AMO is doing and update about:addons to match it.
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
-
Fill stars based on whether the rating is within the 0.5 range of a
0.5-multiple, rather than checking whether the rating is at least as
large as the 0.5-multiple. This follows the boundaries at:
https://github.com/mozilla/addons-frontend/blob/bb9277eeffa1aca38b49c8ed2f4dfa5823def394/src/ui/components/Rating/index.js#L139-L140 -
Use a review star rating instead of re-using the bookmark star.
This is not necessarily to be more consistent with AMO's stars,
but to prevent the stars from becoming non-stars if we ever change
the bookmark icon. The SVG icon is based on the path at:
https://github.com/mozilla/addons-frontend/blob/bb9277eeffa1aca38b49c8ed2f4dfa5823def394/src/ui/components/IconStar/index.js#L19 -
Turn it into a custom element to make re-use easier.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/2209fbf12d8b Match AMO's rating logic in about:addons r=mstriemer,Pike
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/af2c36273f0c Match AMO's rating logic in about:addons r=mstriemer,Pike
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
I was able to reproduce this issue on Firefox 68.0a1 (20190507094727) under Win 7 64-bit.
This issue is verified as fixed on Firefox 68.0a1 (20190509214305) under Win 7 64-bit and Mac OS X 10.14.1.
Please see the attached screenshot.
Description
•