Attachment reading pane im message preview broken for numerous items, cannot resize height.
Categories
(Thunderbird :: Message Reader UI, defect)
Tracking
(thunderbird67 fixed, thunderbird68 fixed)
People
(Reporter: alta88, Assigned: jorgk-bmo)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
2.94 KB,
patch
|
jorgk-bmo
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
If there are numerous items that would create multiple rows, they are now all on one row with a long scrollbar, don't wrap, and the height cannot be sized with the splitter. preferredHeight is probably wrong.
|
||
Updated•6 years ago
|
|
Assignee | |
Comment 1•6 years ago
|
||
On the freshest of fresh builds I tried with 8 attachments and everything is looking 100% normal on Windows. No malfunction to be detected. What am I missing.
Richard can you see an issue anywhere?
|
||
Comment 2•6 years ago
|
||
Jörg, you tried in the message reading attachment pane? In this one I see the issue too.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Sorry, I've worked on too many composition attachment bugs that the "attachment pane" is the area were attachments are visualised in the Write window. Besides, it was alleged that the fix in bug 1526811 (see bug 1526811 comment #20) which was about attachments in the composer's attachment bucket broke this.
That said, my apologies, I see now that the fix in bug 1526811 messed with the richlistbox in general and could have easily affected the preview pane as well. I've done a local backout of rev 66cc9a7a0aaa and the problem goes away. So bug 1526811 regressed this. Now we need to find which part it was.
As Alta88 said, it's most likely this:
https://hg.mozilla.org/comm-central/rev/66cc9a7a0aaa#l2.66
I'll see what I can do.
|
|
Assignee | |
Comment 4•6 years ago
|
||
Straight part backout restoring what Aceman suggested to take out in bug 1526811 comment #9. So much for messing with code at 1:30 AM.
What a mess. So some listboxes have a scrollbox built in and some need to implement it in XBL? OK, maybe those that we extend/implement in XBL.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ce99d912b3d4
restore part of the attachmentlist bindings overzealously removed in rev 66cc9a7a0aaa of bug 1526811. r=me
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 7•6 years ago
|
||
TB 67 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/a3b2ff50ea269c3c9bbaba2fea8711bd34c869d4
Description
•