Closed Bug 1542317 Opened 5 months ago Closed 5 months ago

Attachment reading pane im message preview broken for numerous items, cannot resize height.

Categories

(Thunderbird :: Message Reader UI, defect)

defect
Not set

Tracking

(thunderbird67 fixed, thunderbird68 fixed)

RESOLVED FIXED
Thunderbird 68.0
Tracking Status
thunderbird67 --- fixed
thunderbird68 --- fixed

People

(Reporter: alta88, Assigned: jorgk)

References

Details

(Keywords: regression)

Attachments

(1 file)

If there are numerous items that would create multiple rows, they are now all on one row with a long scrollbar, don't wrap, and the height cannot be sized with the splitter. preferredHeight is probably wrong.

Keywords: regression

On the freshest of fresh builds I tried with 8 attachments and everything is looking 100% normal on Windows. No malfunction to be detected. What am I missing.

Richard can you see an issue anywhere?

Flags: needinfo?(richard.marti)

Jörg, you tried in the message reading attachment pane? In this one I see the issue too.

Flags: needinfo?(richard.marti)

Sorry, I've worked on too many composition attachment bugs that the "attachment pane" is the area were attachments are visualised in the Write window. Besides, it was alleged that the fix in bug 1526811 (see bug 1526811 comment #20) which was about attachments in the composer's attachment bucket broke this.

That said, my apologies, I see now that the fix in bug 1526811 messed with the richlistbox in general and could have easily affected the preview pane as well. I've done a local backout of rev 66cc9a7a0aaa and the problem goes away. So bug 1526811 regressed this. Now we need to find which part it was.

As Alta88 said, it's most likely this:
https://hg.mozilla.org/comm-central/rev/66cc9a7a0aaa#l2.66

I'll see what I can do.

Blocks: 1526811
Summary: Attachment pane broken for numerous items, cannot resize height. → Attachment reading pane im message preview broken for numerous items, cannot resize height.
Attached patch 1542317.patchSplinter Review

Straight part backout restoring what Aceman suggested to take out in bug 1526811 comment #9. So much for messing with code at 1:30 AM.

Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9056249 - Flags: review+
Attachment #9056249 - Flags: approval-comm-beta+

What a mess. So some listboxes have a scrollbox built in and some need to implement it in XBL? OK, maybe those that we extend/implement in XBL.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ce99d912b3d4
restore part of the attachmentlist bindings overzealously removed in rev 66cc9a7a0aaa of bug 1526811. r=me

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
You need to log in before you can comment on or make changes to this bug.