Port Bug 1352113 - Shippable builds for Thunderbird

RESOLVED FIXED in Thunderbird 68.0

Status

task
RESOLVED FIXED
2 months ago
20 days ago

People

(Reporter: jorgk, Assigned: rjl)

Tracking

({regression})

Trunk
Thunderbird 68.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 4 obsolete attachments)

Reporter

Description

2 months ago

Most likely related to the shippable stuff in bug 1352113 although the bustage is more recent.

Flags: needinfo?(rob)
Assignee

Updated

2 months ago
Assignee: nobody → rob
Status: NEW → ASSIGNED
Flags: needinfo?(rob)
Assignee

Comment 1

2 months ago
Posted patch osx_shippable_build.patch (obsolete) — Splinter Review

This will get OSX Try builds working again.
A proper fix will take more time and involve M-C changes. Submitting this in the interest of having working try builds in the meantime.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=145c72a5d1edf7698305385fc63644788d465920

Reporter

Updated

2 months ago
Keywords: leave-open

Comment 2

2 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/760dc9a0cff6
Create shippable build variant for OSX. rs=bustage-fix,jorgk
Reporter

Comment 3

2 months ago

Sorry, I had to back this out since it busted the Daily build:
https://hg.mozilla.org/comm-central/rev/e20446954ee615a5054e0d3c6f6f692b19c4f879

Error was:
Exception: conflict between build-macosx64-shippable/opt:build-macosx64-nightly/opt for route: index.comm.v2.comm-central.nightly.latest.thunderbird.macosx64-opt

Flags: needinfo?(rob)
Assignee

Comment 4

a month ago
Posted patch osx_shippable_build_v2.patch (obsolete) — Splinter Review

Updated patch that replaces the "nightly" variant rather than add to it.

Attachment #9057105 - Attachment is obsolete: true
Flags: needinfo?(rob)

Comment 5

a month ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9a52070b12ae
Create shippable build variant for OSX. rs=bustage-fix,jorgk
Reporter

Comment 6

a month ago

Sorry, I backed this out since I suspected that it busted the Daily build:
https://hg.mozilla.org/comm-central/rev/c4c1ac428ecd8666e445c2ad22bb5080b2a868f0

The error looks somewhat unrelated, but locally the mach taskgraph magic passes:
KeyError: u'build-docker-image-index-task'

EDIT: I guessed correctly, Daily/Nightly is running now.

Assignee

Updated

a month ago
Summary: Mac builds broken on try-comm-central: Exception: Unknown platform(s) [macosx64-shippable] specified for try → Port Bug 1352113 - Shippable builds for Thunderbird
Assignee

Comment 7

a month ago
Posted patch tb_shippable_builds.patch (obsolete) — Splinter Review

This ports the rest of the shippable build changes from bug 1352113.

Full(?) dailyish try build running at:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e4460b0caa51954771f6781040beae60c0c6a363

Attachment #9057974 - Attachment is obsolete: true

Comment 8

a month ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e8744607741f
Port bug 1352113: Implement shippable builds for Thunderbird. rs=jorgk
Reporter

Comment 9

a month ago

Let's see how we go with this.

Keywords: leave-open
Target Milestone: --- → Thunderbird 68.0
Assignee

Comment 11

a month ago

Submitting for feedback from CI team. This will add the necessary scope to create the build-signing-*shippable/opt tasks.

https://taskcluster-artifacts.net/Bvk-au0NT_O_Joq1y4OLbw/1/public/logs/live_backing.log

Attachment #9059419 - Flags: feedback?(dustin)
Assignee

Comment 12

a month ago

Alternative to attachment 9059419 [details] [diff] [review] that should accomplish the same, but following a different precedent for applying the granted scope.

Attachment #9059420 - Flags: feedback?(dustin)
Assignee

Updated

a month ago
Attachment #9059419 - Flags: feedback?(dustin) → feedback?(mozilla)
Assignee

Updated

a month ago
Attachment #9059420 - Flags: feedback?(dustin) → feedback?(mozilla)

(these looked fine to me structurally, but I'm not the expert on signing scopes)

Comment on attachment 9059419 [details] [diff] [review]
ciconfiguration_tb-signing_grant.patch

Review of attachment 9059419 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable, but can you submit it via phabricator?
Attachment #9059419 - Flags: feedback?(mozilla) → feedback+
Comment on attachment 9059420 [details] [diff] [review]
ciconfiguration_tb-signing_grant_ALT.patch

Review of attachment 9059420 [details] [diff] [review]:
-----------------------------------------------------------------

This probably wants a more specific change, as none of the scriptworkers need to be accessible to pushes on comm-central.
Attachment #9059420 - Flags: feedback?(mozilla) → feedback-
Assignee

Comment 16

a month ago

Addresses missing scope error when creating shippable build signing tasks (for
comm-central).
Missing scope is "project:comm:thunderbird:releng:signing:cert:nightly-signing".

This patch follows the approach used by FF and adds the grant to all level 3
comm repositories.

Updated

a month ago
Type: defect → task
Attachment #9060287 - Attachment description: Bug 1542550 - Grant missing scope to permit signing shippable builds. r?tomprince → Bug 1542550 - Grant thunderbird scopes for signing shippable builds on push. r?tomprince
Assignee

Comment 18

23 days ago
Comment on attachment 9062482 [details] [diff] [review]
tb_shippable_builds_v2.patch

Tom updated ci-configuration for us, so I rebased the this patch. It ran on try, and I expect it will run on c-c now.
Attachment #9062482 - Flags: review?(geoff)
Comment on attachment 9062482 [details] [diff] [review]
tb_shippable_builds_v2.patch

Review of attachment 9062482 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/repackage-signing-msi/kind.yml
@@ +12,5 @@
>  kind-dependencies:
>      - repackage-msi
>  
>  only-for-build-platforms:
> +    - win32-shippableopt

Uh oh.
Attachment #9062482 - Flags: review?(geoff) → review+

Comment 21

22 days ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/09b549ec9170
Port bug 1352113: Implement shippable builds for Thunderbird. r=darktrojan CLOSED TREE DONTBUILD

Status: ASSIGNED → RESOLVED
Last Resolved: 22 days ago
Resolution: --- → FIXED
Reporter

Comment 22

22 days ago

Landed with typo fixed. Fingers crossed ;-)

Reporter

Comment 23

22 days ago

Backout:
https://hg.mozilla.org/comm-central/rev/464eae5b48e9548ae0b2626986bfb93422ff5b5d

EDIT: Yep, backing this out gave me a green "Nd" again.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 24

21 days ago

Updated 2019-05-05. Addresses typo flagged in comment 20 and the docker-image-index-task error.

Attachment #9062482 - Attachment is obsolete: true
Reporter

Updated

21 days ago
Keywords: checkin-needed

Comment 25

21 days ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dd29466819f2
Port bug 1352113: Implement shippable builds for Thunderbird. r=darktrojan CLOSED TREE

Status: REOPENED → RESOLVED
Last Resolved: 22 days ago21 days ago
Keywords: checkin-needed
Resolution: --- → FIXED
Reporter

Comment 26

21 days ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 27

21 days ago

Yet another missing scope that has to be granted through ci-configuratioin.

[task 2019-05-05T22:02:47.132Z] Client ID task-client/DiT6NebeTtup-Oayu3e1hg/1/on/us-east-1/i-086f1ed327b10ad3a/until/1557094926.406 does not have sufficient scopes and is missing the following scopes:
[task 2019-05-05T22:02:47.132Z]
[task 2019-05-05T22:02:47.133Z] [task 2019-05-05T22:02:47.133Z] project:comm:thunderbird:releng:signing:cert:nightly-signing [task 2019-05-05T22:02:47.136Z]

Comment 29

20 days ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b58e5d1520e0
Port bug 1352113: Implement shippable builds for Thunderbird. r=darktrojan DONTBUILD

Status: REOPENED → RESOLVED
Last Resolved: 21 days ago20 days ago
Resolution: --- → FIXED

Comment 31

20 days ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d9e252049461
Port bug 1333255: Add image-index task to Thunderbird. rs=jorgk DONTBUILD
You need to log in before you can comment on or make changes to this bug.