1542550 - Port Bug 1352113 - Shippable builds for Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Jorg K (CEST = GMT+2)]

Most likely related to the shippable stuff in bug 1352113 although the bustage is more recent.

Comment 1

[Rob Lemley [:rjl]]

Attachment: osx_shippable_build.patch

This will get OSX Try builds working again.
A proper fix will take more time and involve M-C changes. Submitting this in the interest of having working try builds in the meantime.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=145c72a5d1edf7698305385fc63644788d465920

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/760dc9a0cff6
Create shippable build variant for OSX. rs=bustage-fix,jorgk

Comment 3

[Jorg K (CEST = GMT+2)]

Sorry, I had to back this out since it busted the Daily build:
https://hg.mozilla.org/comm-central/rev/e20446954ee615a5054e0d3c6f6f692b19c4f879

Error was:
Exception: conflict between build-macosx64-shippable/opt:build-macosx64-nightly/opt for route: index.comm.v2.comm-central.nightly.latest.thunderbird.macosx64-opt

Comment 4

[Rob Lemley [:rjl]]

Attachment: osx_shippable_build_v2.patch

Updated patch that replaces the "nightly" variant rather than add to it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9a52070b12ae
Create shippable build variant for OSX. rs=bustage-fix,jorgk

Comment 6

[Jorg K (CEST = GMT+2)]

Sorry, I backed this out since I suspected that it busted the Daily build:
https://hg.mozilla.org/comm-central/rev/c4c1ac428ecd8666e445c2ad22bb5080b2a868f0

The error looks somewhat unrelated, but locally the mach taskgraph magic passes:
KeyError: u'build-docker-image-index-task'

EDIT: I guessed correctly, Daily/Nightly is running now.

Comment 7

[Rob Lemley [:rjl]]

Attachment: tb_shippable_builds.patch

This ports the rest of the shippable build changes from bug 1352113.

Full(?) dailyish try build running at:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e4460b0caa51954771f6781040beae60c0c6a363

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8744607741f
Port bug 1352113: Implement shippable builds for Thunderbird. rs=jorgk

Comment 9

[Jorg K (CEST = GMT+2)]

Let's see how we go with this.

Comment 10

[Jorg K (CEST = GMT+2)]

Hmm, that busted C-C treeherder, but the same thing works on try:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e8744607741f5b92e2edff17eb62d1137048af45

Backout:
https://hg.mozilla.org/comm-central/rev/ddfc8b3514165e69dbf83fdb4b7928555268f49a

Comment 11

[Rob Lemley [:rjl]]

Attachment: ciconfiguration_tb-signing_grant.patch

Submitting for feedback from CI team. This will add the necessary scope to create the build-signing-*shippable/opt tasks.

https://taskcluster-artifacts.net/Bvk-au0NT_O_Joq1y4OLbw/1/public/logs/live_backing.log

Comment 12

[Rob Lemley [:rjl]]

Attachment: ciconfiguration_tb-signing_grant_ALT.patch

Alternative to attachment 9059419 [details] [diff] [review] that should accomplish the same, but following a different precedent for applying the granted scope.

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

(these looked fine to me structurally, but I'm not the expert on signing scopes)

Comment 14

[Tom Prince [:tomprince]]

Comment on attachment 9059419 [details] [diff] [review]
ciconfiguration_tb-signing_grant.patch

Review of attachment 9059419 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable, but can you submit it via phabricator?

Comment 15

[Tom Prince [:tomprince]]

Comment on attachment 9059420 [details] [diff] [review]
ciconfiguration_tb-signing_grant_ALT.patch

Review of attachment 9059420 [details] [diff] [review]:
-----------------------------------------------------------------

This probably wants a more specific change, as none of the scriptworkers need to be accessible to pushes on comm-central.

Comment 16

[Rob Lemley [:rjl]]

Attachment: Bug 1542550 - Grant thunderbird scopes for signing shippable builds on push. r?tomprince

Addresses missing scope error when creating shippable build signing tasks (for
comm-central).
Missing scope is "project:comm:thunderbird:releng:signing:cert:nightly-signing".

This patch follows the approach used by FF and adds the grant to all level 3
comm repositories.

Comment 17

[Rob Lemley [:rjl]]

Attachment: tb_shippable_builds_v2.patch

Rebased 2019-05-03.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1426f60abc527fb0df3b06a2b42030af9e0e29e5

Comment 18

[Rob Lemley [:rjl]]

Comment on attachment 9062482 [details] [diff] [review]
tb_shippable_builds_v2.patch

Tom updated ci-configuration for us, so I rebased the this patch. It ran on try, and I expect it will run on c-c now.

Comment 19

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1426f60abc527fb0df3b06a2b42030af9e0e29e5
And I ran one, too:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fe90a2c95c01254e441d8fc0196b06f9ca7e6bc6

Comment 20

[Geoff Lankow (:darktrojan)]

Comment on attachment 9062482 [details] [diff] [review]
tb_shippable_builds_v2.patch

Review of attachment 9062482 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/repackage-signing-msi/kind.yml
@@ +12,5 @@
>  kind-dependencies:
>      - repackage-msi
>  
>  only-for-build-platforms:
> +    - win32-shippableopt

Uh oh.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/09b549ec9170
Port bug 1352113: Implement shippable builds for Thunderbird. r=darktrojan CLOSED TREE DONTBUILD

Comment 22

[Jorg K (CEST = GMT+2)]

Landed with typo fixed. Fingers crossed ;-)

Comment 23

[Jorg K (CEST = GMT+2)]

Backout:
https://hg.mozilla.org/comm-central/rev/464eae5b48e9548ae0b2626986bfb93422ff5b5d

EDIT: Yep, backing this out gave me a green "Nd" again.

Comment 24

[Rob Lemley [:rjl]]

Attachment: tb_shippable_builds_v3.patch

Updated 2019-05-05. Addresses typo flagged in comment 20 and the docker-image-index-task error.

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd29466819f2
Port bug 1352113: Implement shippable builds for Thunderbird. r=darktrojan CLOSED TREE

Comment 26

[Jorg K (CEST = GMT+2)]

Backout:
https://hg.mozilla.org/comm-central/rev/d9ee35b18a0da38d841b255a895e42a8453b355a

Comment 27

[Rob Lemley [:rjl]]

Yet another missing scope that has to be granted through ci-configuratioin.

[task 2019-05-05T22:02:47.132Z] Client ID task-client/DiT6NebeTtup-Oayu3e1hg/1/on/us-east-1/i-086f1ed327b10ad3a/until/1557094926.406 does not have sufficient scopes and is missing the following scopes:
[task 2019-05-05T22:02:47.132Z]
[task 2019-05-05T22:02:47.133Z] [task 2019-05-05T22:02:47.133Z] project:comm:thunderbird:releng:signing:cert:nightly-signing [task 2019-05-05T22:02:47.136Z]

Comment 28

[Rob Lemley [:rjl]]

Attachment: Bug 1542550 - Add missing nightly-signing scope to comm-central. r?tomprince

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b58e5d1520e0
Port bug 1352113: Implement shippable builds for Thunderbird. r=darktrojan DONTBUILD

Comment 30

[Rob Lemley [:rjl]]

Attachment: tb_image-index_task.patch

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d9e252049461
Port bug 1333255: Add image-index task to Thunderbird. rs=jorgk DONTBUILD

Comment 32

[Rob Lemley [:rjl]]

Attachment: Bug 1542550 - Add comm-esr68 repository; r?tomprince

Repository is already set up.

Comment 33

[Phabricator Automation]

Comment on attachment 9076633 [details]
Bug 1542550 - Add comm-esr68 repository; r?tomprince

Revision D37316 was moved to bug 1561934. Setting attachment 9076633 [details] to obsolete.