1542556 - [Automated review] Incorrect consideration of "known to be nullptr"

Status: RESOLVED DUPLICATE of bug 1544767

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Phabricator URL: https://phabricator.services.mozilla.com/D26423

Dereferencing "aStartPoint->GetContainerAsText()", which is known to be "nullptr".
The path that leads to this defect is:

• editor/libeditor/WSRunObject.cpp:1307:
  path: Condition "!aStartPoint->IsSet()", taking false branch..

This means aStartPoint->mParent is not nullptr.

editor/libeditor/WSRunObject.cpp:1307:
    path: Condition "NS_warn_if_impl(!aStartPoint->IsSet(), "!aStartPoint.IsSet()", "/tmp/staticanalysis/sa-unified/editor/libeditor/WSRunObject.cpp", 1307)", taking false branch..

(out of scope of this bug, I feel odd to include debug only code here)

editor/libeditor/WSRunObject.cpp:1316:
    path: Condition "aStartPoint == aEndPoint", taking false branch..

This means that the range between aStartPoint and aEndPoint is not collapsed.

editor/libeditor/WSRunObject.cpp:1324:
    path: Condition "aStartPoint->GetContainer() == aEndPoint->GetContainer()", taking true branch..

This means that the range is in same node.

editor/libeditor/WSRunObject.cpp:1324:
    path: Condition "aStartPoint->IsInTextNode()", taking true branch..

This means that the range is in a text node.

editor/libeditor/WSRunObject.cpp:1326:
    returned_null: "GetContainerAsText" returns "nullptr" (checked 3 out of 3 times)..

So, this returns aStartParent->mParent as Text (text node). I.e., not nullptr.

editor/libeditor/WSRunObject.cpp:1326:
    dereference: Dereferencing "aStartPoint->GetContainerAsText()", which is known to be "nullptr"..

So, not return nullptr.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Yeah, coverity has false positive...

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:sylvestre, could you have a look please?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

We know tag the false positive ratio. So, closing