Closed Bug 1542681 Opened 5 years ago Closed 5 years ago

remove grid usage from comm/mailnews/base/content/folderProps.xul

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → khushil324
Status: NEW → ASSIGNED
Attached patch remove_grid_folderProps.patch (obsolete) — Splinter Review
Attachment #9056747 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9056747 [details] [diff] [review]
remove_grid_folderProps.patch

Review of attachment 9056747 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just a small nit. r=mkmelin

::: mailnews/base/content/folderProps.xul
@@ +82,5 @@
> +            label="&folderRebuildSummaryFile2.label;"
> +            oncommand="RebuildSummaryInformation();"
> +            accesskey="&folderRebuildSummaryFile2.accesskey;"
> +            tooltiptext="&folderRebuildSummaryFileTip2.label;"
> +            align="center"/>

the attributes should align under id like they used to
Attachment #9056747 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9056747 - Attachment is obsolete: true
Attachment #9056856 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f9d017083303
remove grid usage from folderProps.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
Type: defect → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: