1542707 - Permafailing Android artifact Nightly jobs (only running on Try) Android 4.0 API16+ opt and Android 5.0 AArch64 opt

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

This is the try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70a5d52a9ede39cb26efc19cb24a806300415642&group_state=expanded&selectedJob=238330178

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[task 2019-03-12T17:15:23.466Z] 17:15:23 INFO - 17:15:23 INFO - Multi-locale packaging requires the full (non-artifact) 'RecursiveMake' build backend; got ['FasterMake+RecursiveMake'].
[task 2019-03-12T17:15:23.481Z] 17:15:23 INFO - 17:15:23 ERROR - Return code: 1

Can running/requesting those jobs be prevented?

Comment 2

[Chris Peterson [:cpeterson]]

chmanchester, these Try errors appear to be related to Android PGO configuration.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

The API16+ build is failing due to the PGO configuration, but the AArch64 build is failing for another reason. I don't think we've ever intended to replace Nightly builds with artifact builds in automation, the artifact code doesn't know to look for them, so we may end up with artifacts from an opt or pgo build. That might work ok, but I don't think we're expecting it. For shippable everything works alright, for Android nightlies for now I think we should just stop nightly builds from being converted into artifact builds.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Chris Manchester (:chmanchester) from comment #3)

The API16+ build is failing due to the PGO configuration, but the AArch64 build is failing for another reason. I don't think we've ever intended to replace Nightly builds with artifact builds in automation, the artifact code doesn't know to look for them, so we may end up with artifacts from an opt or pgo build. That might work ok, but I don't think we're expecting it. For shippable everything works alright, for Android nightlies for now I think we should just stop nightly builds from being converted into artifact builds.

We used to have a flag for this, but I think post Bug 1530908 we do not. glandium, how do we manage this after your earlier work?

Comment 5

[Chris Manchester (limited bugmail, email directly)]

The new check is here: https://searchfox.org/mozilla-central/rev/8d78f219702286c873860f39f9ed78bad1a6d062/taskcluster/taskgraph/transforms/build.py#156

I have a patch that adds a nightly check there that looks fine on try.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1542707 - Don't replace 'nightly' jobs with artifact builds on try.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17b96c33164e
Don't replace 'nightly' jobs with artifact builds on try. r=glandium

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/17b96c33164e