Closed
Bug 1542758
Opened 3 years ago
Closed 3 years ago
mozjemalloc.cpp should use posix_madvise on Solaris
Categories
(Firefox :: Untriaged, defect)
Firefox
Untriaged
Tracking
()
RESOLVED
FIXED
Firefox 68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: petr.sumbera, Assigned: petr.sumbera)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0
Steps to reproduce:
On Solaris madvise is declared like:
int madvise(caddr_t addr, size_t len, int advice);
On Linux:
int madvise(void *addr, size_t length, int advice);
(first argument type: caddr_t vs void*)
Therefore we should use on Solaris posix_madvise which is:
int posix_madvise(void *addr, size_t len, int advice);
(and it internally calls madvise anyway)
This would be the same approach as it was used in different places (e.g. Bug 963983).
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9f68f966c69
mozjemalloc.cpp should use posix_madvise on Solaris r=glandium
Keywords: checkin-needed
Comment 3•3 years ago
|
||
bugherder |
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Updated•3 years ago
|
Assignee: nobody → petr.sumbera
You need to log in
before you can comment on or make changes to this bug.
Description
•