1542758 - mozjemalloc.cpp should use posix_madvise on Solaris

Status: RESOLVED FIXED

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

On Solaris madvise is declared like:

int madvise(caddr_t addr, size_t len, int advice);

On Linux:

int madvise(void *addr, size_t length, int advice);

(first argument type: caddr_t vs void*)

Therefore we should use on Solaris posix_madvise which is:

int posix_madvise(void *addr, size_t len, int advice);

(and it internally calls madvise anyway)

This would be the same approach as it was used in different places (e.g. Bug 963983).

Comment 1

[Petr Sumbera]

Attachment: Bug 1542758 - mozjemalloc.cpp should use posix_madvise on Solaris

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9f68f966c69
mozjemalloc.cpp should use posix_madvise on Solaris r=glandium

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d9f68f966c69