Closed Bug 1542758 Opened 3 years ago Closed 3 years ago

mozjemalloc.cpp should use posix_madvise on Solaris

Categories

(Firefox :: Untriaged, defect)

Product:
Firefox
Component:
Untriaged
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file)

Bug 1542758 - mozjemalloc.cpp should use posix_madvise on Solaris
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

On Solaris madvise is declared like:

int madvise(caddr_t addr, size_t len, int advice);

On Linux:

int madvise(void *addr, size_t length, int advice);

(first argument type: caddr_t vs void*)

Therefore we should use on Solaris posix_madvise which is:

int posix_madvise(void *addr, size_t len, int advice);

(and it internally calls madvise anyway)

This would be the same approach as it was used in different places (e.g. Bug 963983).

Keywords: checkin-needed

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9f68f966c69
mozjemalloc.cpp should use posix_madvise on Solaris r=glandium

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/d9f68f966c69

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → petr.sumbera
You need to log in before you can comment on or make changes to this bug.