Closed Bug 1542878 Opened 1 year ago Closed 1 year ago

Build system should look for an up-to-date cbindgen in ~/.mozbuild even if the one in ~/.cargo is too old

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bholley, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

|./mach bootstrap| will install cbindgen in ~/.mozbuild, whereas |cargo install cbindgen| will install it in ~/.cargo.

At present, the build system looks lin ~/.cargo first. If it finds an out-of-date cbindgen, the build will fail. It should either check both locations and pick a valid version, or it should just always use the one in .mozbuild.

Emilio is going to fix this.

Flags: needinfo?(emilio)
Blocks: mach-busted
Blocks: 1540533
Flags: needinfo?(emilio)

Before this patch, we first find an executable, then check the version. So if
the first executable we find is outdated, we won't look for others.

Instead, check each of them for different versions manually. This will also
unblock bug 1540533, since at that point we know that we'll be able to find
a cbindgen with the right version.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30271e4881e7
Check all the cbindgen executables before failing configure. r=froydnj
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.