1542878 - Build system should look for an up-to-date cbindgen in ~/.mozbuild even if the one in ~/.cargo is too old

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bobby Holley (:bholley)]

|./mach bootstrap| will install cbindgen in ~/.mozbuild, whereas |cargo install cbindgen| will install it in ~/.cargo.

At present, the build system looks lin ~/.cargo first. If it finds an out-of-date cbindgen, the build will fail. It should either check both locations and pick a valid version, or it should just always use the one in .mozbuild.

Emilio is going to fix this.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1542878 - Check all the cbindgen executables before failing configure. r=#build

Before this patch, we first find an executable, then check the version. So if
the first executable we find is outdated, we won't look for others.

Instead, check each of them for different versions manually. This will also
unblock bug 1540533, since at that point we know that we'll be able to find
a cbindgen with the right version.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30271e4881e7
Check all the cbindgen executables before failing configure. r=froydnj

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/30271e4881e7