Closed Bug 1542918 Opened 4 years ago Closed 4 years ago

Debug Assertion on page already registered in the profiler browsing to


(Core :: Gecko Profiler, defect, P2)

52 Branch



Tracking Status
firefox-esr60 --- unaffected
firefox67 --- wontfix
firefox68 --- fixed


(Reporter: jesup, Assigned: canova)


(Blocks 1 open bug, Regression)


(Keywords: assertion, regression)


(3 files)

STR: with a fairly new profile with a Debug non-opt build, browse to a site (I used, then start the profiler (already installed) and browse to

Hit an assertion at tools/profiler/core/platform.cpp:323 due to a page already being in the page cache. Dumps of the 3 pages in the cache and the new page are attached -- the collision was on HistoryId 13, which one has as about:blank, and the other has as ""... (truncated).

They compare as equal in PageInformation::Equals() (same docshell, id, and subframe).

Unsure if this is repeatable. Note: browsing with a non-opt debug build is Very Slow....

I presume this was introduced by bug 1417976

Attached file docshell_problem
Flags: needinfo?(canaltinova)

If you remove the ifdef, and make it MOZ_RELEASE_ASSERT(), it failed on the the first pageload of youtube for me (after loading Trying again and 1 or two other URLs didn't hit, but clearly there's a hole here.

Attached file assertion2

Assertion with opt build (modified to include the assert) on a CNN page.

Thanks for filing this Randell. I'm aware of that issue and actually I have a fix for that here:
But I wasn't working on that for a while after publishing the patch because of other works that I need to finish. I came back to it and finishing up/writing some tests now. It will be fixed after that.

Depends on: 1512500
Flags: needinfo?(canaltinova)
Priority: -- → P2

Nazim, we need to disable this, or fix it - it makes debug builds die with the profiler way too often. Currently I build with patches to make that code an #if 0 to avoid crashing

Flags: needinfo?(canaltinova)

Ok, how about disabling it until we fix it? Will submit a patch that disables that for now. Sorry about that.

Flags: needinfo?(canaltinova)
Pushed by
Disable the assertion in profiler page registration until we fix it r=jesup
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → canaltinova
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.