1543041 - Port bug 1355073 to quantumbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Dão Gottwald [:dao]]

Bug 1355073 only patched urlbarBindings.xml but that's going away. The fix should be ported to UrlbarInput.

Comment 1

[Marco Bonardo [:mak]]

I wonder if this should block QB release, it would end up being a regression in the end.
Maybe PhoenixAbhishek may be interested into fixing this as well, since they fixed the original bug.
The code is here https://searchfox.org/mozilla-central/rev/d302c3058330a57f238be4062fddea629311ce66/browser/components/urlbar/UrlbarInput.jsm#1515

Comment 2

[PhoenixAbhishek]

I'll update this once my exams are done next week :)
Also, whom should I add as reviewer?
You or Johann?

Comment 3

[Johann Hofmann [:johannh]]

I could probably review this if necessary but it's probably better to ask :mak since he's more familiar with Quantum Bar.

Thanks!

Comment 4

[Dão Gottwald [:dao]]

Are you still going to work on this?

Comment 5

[PhoenixAbhishek]

Yes, working on the patch right now :)

Comment 6

[Dão Gottwald [:dao]]

Alright, thanks!

Comment 7

[PhoenixAbhishek]

Attachment: Bug 1543041 - Port bug 1355073 to quantumbar. r=mak,johannh!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d499ab0ad0da
Port bug 1355073 to quantumbar. r=mak

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d499ab0ad0da