Closed Bug 1543041 Opened 1 year ago Closed 1 year ago

Port bug 1355073 to quantumbar

Categories

(Firefox :: Address Bar, defect, P3)

defect
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: dao, Assigned: phoenixgyaan)

References

Details

Attachments

(1 file)

Bug 1355073 only patched urlbarBindings.xml but that's going away. The fix should be ported to UrlbarInput.

Points: --- → 1
Priority: -- → P3

I wonder if this should block QB release, it would end up being a regression in the end.
Maybe PhoenixAbhishek may be interested into fixing this as well, since they fixed the original bug.
The code is here https://searchfox.org/mozilla-central/rev/d302c3058330a57f238be4062fddea629311ce66/browser/components/urlbar/UrlbarInput.jsm#1515

Flags: needinfo?(phoenixgyaan)

I'll update this once my exams are done next week :)
Also, whom should I add as reviewer?
You or Johann?

Flags: needinfo?(phoenixgyaan) → needinfo?(mak77)

I could probably review this if necessary but it's probably better to ask :mak since he's more familiar with Quantum Bar.

Thanks!

Flags: needinfo?(mak77)

Are you still going to work on this?

Flags: needinfo?(phoenixgyaan)

Yes, working on the patch right now :)

Flags: needinfo?(phoenixgyaan)

Alright, thanks!

Assignee: nobody → phoenixgyaan
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.