1543071 - Support puppeteer's Page.close

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

This is used by Wordpress test suite in order to close the browser at the end of tests.

Puppeteer's Page.close uses CDP's Target.close:
https://github.com/GoogleChrome/puppeteer/blob/9ef23b17542cc630e502fcf6689bf6b20fa9911b/lib/Page.js#L991-L992

      await this._client._connection.send('Target.closeTarget', { targetId: this._target._targetId });
      await this._target._isClosedPromise;

And CDP's Target.targetDestroyed event:
https://github.com/GoogleChrome/puppeteer/blob/3bea5d6017c36ab848a0c0b0c809e2a6b5259749/experimental/puppeteer-firefox/lib/Browser.js#L190-L193

  _onTargetDestroyed({targetId}) {
    const target = this._targets.get(targetId);
    this._targets.delete(targetId);
    target._closedCallback();

I'll ignore the {runBeforeUnload: true} option for now and instead open a followup. Supporting this optional argument depends on CDP's Page.close method.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Thanks for correcting the component.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1543071 - Implement Target.targetDestroyed event

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1543071 - Implement Target.closeTarget

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1543071 - Implement Target.targetDestroyed event

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1543071 - Implement Target.closeTarget

Depends on D35106

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1543071 - Test remote Target.closeTarget and targetDestroyed event

Depends on D35107

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f24caf8d9666
Implement Target.targetDestroyed event r=ato
https://hg.mozilla.org/integration/autoland/rev/430bb08ecd68
Implement Target.closeTarget r=ato
https://hg.mozilla.org/integration/autoland/rev/b16a957f53f7
Test remote Target.closeTarget and targetDestroyed event r=ochameau

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f24caf8d9666
https://hg.mozilla.org/mozilla-central/rev/430bb08ecd68
https://hg.mozilla.org/mozilla-central/rev/b16a957f53f7

Comment 9

[Alexandre Poirot [:ochameau]]

I believe that bug 1560127 regression is rather related to bug 1545147.