Closed
Bug 1543144
Opened 6 years ago
Closed 6 years ago
about:telemetry doesn't work right anymore in RTL
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox66 | --- | unaffected |
| firefox67 | --- | unaffected |
| firefox68 | --- | fixed |
People
(Reporter: Gijs, Assigned: berning5)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
https://searchfox.org/mozilla-central/search?q=%5Bdir&case=false®exp=false&path=abouttel
all of these are broken now that we don't set [dir=locale.dir] anymore.
We should replace them with :-moz-locale-dir(rtl) pseudoselectors, and check that that works (if not, use :dir(rtl) instead, but be careful with that...).
Avery, do you have cycles to take this?
Flags: needinfo?(berning5)
|
Reporter | |
Comment 1•6 years ago
|
||
One obvious visual side-effect here is that if you click the 'current ping' dropdown on the right hand side of the page in RTL, the popup still opens on the left hand side...
It may be possible to use the direction-agnostic forms of positioning to just avoid having RTL special cases here.
|
Assignee | |
Comment 2•6 years ago
|
||
Sorry for the late response! I can take take this, I'll have it finished when I head home.
Flags: needinfo?(berning5)
|
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → berning5
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Updated•6 years ago
|
Priority: -- → P1
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2311a8b67ba4
Fixed CSS for aboutTelemetry on RTL, r=jaws
|
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•