Closed Bug 1543144 Opened 7 months ago Closed 6 months ago

about:telemetry doesn't work right anymore in RTL

Categories

(Toolkit :: Telemetry, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: berning5)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

https://searchfox.org/mozilla-central/search?q=%5Bdir&case=false&regexp=false&path=abouttel

all of these are broken now that we don't set [dir=locale.dir] anymore.

We should replace them with :-moz-locale-dir(rtl) pseudoselectors, and check that that works (if not, use :dir(rtl) instead, but be careful with that...).

Avery, do you have cycles to take this?

Flags: needinfo?(berning5)

One obvious visual side-effect here is that if you click the 'current ping' dropdown on the right hand side of the page in RTL, the popup still opens on the left hand side...

It may be possible to use the direction-agnostic forms of positioning to just avoid having RTL special cases here.

Sorry for the late response! I can take take this, I'll have it finished when I head home.

Flags: needinfo?(berning5)
Assignee: nobody → berning5
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2311a8b67ba4
Fixed CSS for aboutTelemetry on RTL, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.