Closed Bug 1523741 Opened 7 months ago Closed 5 months ago

Convert aboutTelemetry.dtd to use Fluent instead

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: berning5, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

aboutTelemetry.dtd ( https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd ) is only used from about:telemetry .

It should be a pretty straightforward (and mostly markup-only) conversion.

Priority: -- → P3
Whiteboard: [good first bug][lang=dtd]
Whiteboard: [good first bug][lang=dtd]
Assignee: nobody → berning5
Status: NEW → ASSIGNED
Attachment #9045086 - Attachment description: Bug 1523741 - Converting legacy aboutTelemetry to Fluent aboutTelemetry, r?jaws → Bug 1523741 - Converting legacy aboutTelemetry to Fluent aboutTelemetry, r?flod
Blocks: 1539759

Heads-up: bug 1539257 is planning to make changes to both strings and code in about:telemetry, one of the two is going to have to rebase, and it would be great to not expose strings in DTD/Properties, knowing that we need to move away from them.

I am happy to rebuild my patch to the new standard if this patch is close to landing. The timeframe of bug 1539257 being needed is "soonish but not today", though, so if this will take longer than, say, the end of this week I would like to move ahead with landing it first.

Flags: needinfo?(gijskruitbosch+bugs)
See Also: → 1539257

Redirecting to Jared who's reviewing this patch. I don't know if this is likely to be ready by the end of the week.

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(jaws)

(In reply to Chris H-C :chutten from comment #3)

I am happy to rebuild my patch to the new standard if this patch is close to landing. The timeframe of bug 1539257 being needed is "soonish but not today", though, so if this will take longer than, say, the end of this week I would like to move ahead with landing it first.

Can you please rebase on top of this patch? Avery has said that he will make sure this gets fixed before the end of this week.

Flags: needinfo?(jaws)

(needinfo for comment #5)

Flags: needinfo?(chutten)

I'll await its landing. Let me know if you'd like a Telemetry Peer to have a look.

Flags: needinfo?(chutten)
Blocks: 1539257
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7e40ec0c948d
Converting legacy aboutTelemetry to Fluent aboutTelemetry, r=jaws,flod,Gijs

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=7e40ec0c948d98106fcb558c7650889f10f399a7&searchStr=en-us&selectedJob=238597060

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238597060&repo=autoland&lineNumber=2127

Backout link: https://hg.mozilla.org/integration/autoland/rev/dc53fe5c9cedaf4b7620ce76b7f72af51f31948f

[task 2019-04-06T17:18:59.174Z] 17:18:59 INFO - 1554571139170 Marionette DEBUG 6 <- [1,52,null,{"value":"<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="en-US">\n<head>\n <title data-l10n-id= ... "about:webrtc">about:webrtc</a></li><li><a href="about:welcome">about:welcome</a></li></ul>\n </div>\n</body>\n</html>"}]
[task 2019-04-06T17:18:59.175Z] 17:18:59 INFO - 1554571139173 Marionette DEBUG 6 -> [0,53,"Marionette:SetContext",{"value":"chrome"}]
[task 2019-04-06T17:18:59.234Z] 17:18:59 INFO - TEST-UNEXPECTED-ERROR | testing/firefox-ui/tests/puppeteer/test_l10n.py TestL10n.test_dtd_entity_content | NoSuchElementException: Entity with id='aboutTelemetry.homeSection' hasn't been found
[task 2019-04-06T17:18:59.234Z] 17:18:59 INFO - stacktrace:
[task 2019-04-06T17:18:59.237Z] 17:18:59 INFO - WebDriverError@chrome://marionette/content/error.js:179:5
[task 2019-04-06T17:18:59.237Z] 17:18:59 INFO - NoSuchElementError@chrome://marionette/content/error.js:389:5
[task 2019-04-06T17:18:59.239Z] 17:18:59 INFO - l10n.localizeEntity@chrome://marionette/content/l10n.js:60:11
[task 2019-04-06T17:18:59.240Z] 17:18:59 INFO - GeckoDriver.prototype.localizeEntity@chrome://marionette/content/driver.js:3476:15
[task 2019-04-06T17:18:59.241Z] 17:18:59 INFO - despatch@chrome://marionette/content/server.js:289:40
[task 2019-04-06T17:18:59.242Z] 17:18:59 INFO - execute@chrome://marionette/content/server.js:262:16
[task 2019-04-06T17:18:59.243Z] 17:18:59 INFO - onPacket/<@chrome://marionette/content/server.js:235:20
[task 2019-04-06T17:18:59.244Z] 17:18:59 INFO - onPacket@chrome://marionette/content/server.js:236:9
[task 2019-04-06T17:18:59.244Z] 17:18:59 INFO - _onJSONObjectReady/<@chrome://marionette/content/transport.js:492:20
[task 2019-04-06T17:18:59.246Z] 17:18:59 INFO - Traceback (most recent call last):
[task 2019-04-06T17:18:59.247Z] 17:18:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 159, in run
[task 2019-04-06T17:18:59.249Z] 17:18:59 INFO - testMethod()
[task 2019-04-06T17:18:59.249Z] 17:18:59 INFO - File "/builds/worker/workspace/build/tests/firefox-ui/tests/testing/firefox-ui/tests/puppeteer/test_l10n.py", line 34, in test_dtd_entity_content
[task 2019-04-06T17:18:59.250Z] 17:18:59 INFO - value = self.l10n.localize_entity(dtds, 'aboutTelemetry.homeSection')
[task 2019-04-06T17:18:59.252Z] 17:18:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/firefox_puppeteer/api/l10n.py", line 58, in localize_entity
[task 2019-04-06T17:18:59.252Z] 17:18:59 INFO - return self._l10nMarionette.localize_entity(dtd_urls, entity_id)
[task 2019-04-06T17:18:59.254Z] 17:18:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/localization.py", line 42, in localize_entity
[task 2019-04-06T17:18:59.254Z] 17:18:59 INFO - body, key="value")
[task 2019-04-06T17:18:59.255Z] 17:18:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/decorators.py", line 26, in _
[task 2019-04-06T17:18:59.256Z] 17:18:59 INFO - return func(*args, **kwargs)
[task 2019-04-06T17:18:59.257Z] 17:18:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 598, in _send_message
[task 2019-04-06T17:18:59.257Z] 17:18:59 INFO - self._handle_error(err)
[task 2019-04-06T17:18:59.263Z] 17:18:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 618, in _handle_error
[task 2019-04-06T17:18:59.264Z] 17:18:59 INFO - raise errors.lookup(error)(message, stacktrace=stacktrace)
[task 2019-04-06T17:18:59.266Z] 17:18:59 INFO - TEST-INFO took 608ms

Flags: needinfo?(berning5)
Flags: needinfo?(berning5)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/61f5baa6ed8c
Converting legacy aboutTelemetry to Fluent aboutTelemetry, r=jaws,flod,Gijs
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1543144
Regressions: 1546093
Regressions: 1546101
Regressions: 1562947
You need to log in before you can comment on or make changes to this bug.