Closed Bug 1543375 Opened 6 years ago Closed 3 years ago

[BinAST] Add the binjs-ref encoder to tooltool

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: tcampbell, Unassigned)

References

Details

We have a number of binjs generated files in tree for tests but don't have any audit/reproduction chain for them. My understanding is that this is where the tooltool system for CI is of use. We can have specific versions of binjs-ref recorded there and explicitly updated without needed to vendor it all into mozilla-central.

https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool

Priority: -- → P3

So, we'll need a snapshot of binjs-ref, including dependencies, right? In turn, binjs-ref depends on some Node packages. Will this work?

Flags: needinfo?(tcampbell)

The eslint package bundles its node_modules directory and occasionally updates. It is probably a good model to follow.

https://searchfox.org/mozilla-central/source/tools/lint/eslint/update.sh
https://searchfox.org/mozilla-central/source/tools/lint/eslint/manifest.tt

Flags: needinfo?(tcampbell)
See Also: → 1561560
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.