1543507 - Etherpad-Pro: left/opening bracket (German keyboard) not working in Firefox-66.0.2

Status: RESOLVED WONTFIX

(Core :: DOM: Events, defect)

Description

[kolAflash]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Since some time the left/opening bracket on the German keyboard (shift+8) is being interpreted as arrow-down. So I can't type a left bracket. (copy-pasting a bracket works)

https://upload.wikimedia.org/wikipedia/commons/b/b0/German-T2-Keyboard-Prototype-May-2012.jpg

It's broken in Firefox-66.0.2. (openSUSE-15.0 Linux and Windows-8)

It's working in Firefox<=63 (Windows and Linux) and Chromium-73 (Linux).

Sadly I see now way to report it to Etherpad-Pro, because their community moved on to Etherpad-Lite. But there a still a lot of Etherpad-Pro instances out there. And because it's working with older Firefox versions, I thought it might be an Firefox regression!?

Tried it here and in some other pads:
https://pads.ccc.de/IQdtFrj0fn
Type (German keyboard): Shift+8

Actual results:

current line gets marked

(more shift+8 pressing marks the next lines)

Expected results:

"(" should be entered

Comment 1

[Adrian Florinescu [:aflorinescu]]

Reproduced on Fx 66.0.3, 67.0b11 20190415085659 ,68.0a1 20190418221600:

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2f968d0631f513abd33a76f564a9c2b32377216c&tochange=70335d3f41881cd85b99a23342fc254b3783638f

I don't think this subject is so simple, so Masayuki, can you please take a look.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Etherpad-Lite fixed similar bug in upstream before our release, see bug 1496284. So, we cannot do anything for the older product, Etherpad-Pro, since we cannot create blacklist including every instance. Please maintain the blacklist, "dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode" in about:config, by yourself.

Or, if we can detect current application is Etherpad-Pro or buggy ACE2 editor version, we can add a hack like bug 1514940, though. Feel free to reopen this bug if there is an object which can consider it. There is window.Ace2Editor(), but I don't see version number of something in it.

Comment 3

[kolAflash]

I'm not an Etherpad developer, so don't know anything special about how to identify Ehterpad-Pro.

But thanks for the blacklisting workaround! It works fine.

Comment 4

[Mike Taylor [:miketaylr]]

I still haven't been able to find anything useful here. Etherpad has the option to send a Git hash (to represent version) via a Server header, but it's not on by default -- but a SHA1 checksum won't help us anyways.

There's a window.clientVars object, but nothing useful there either.