Closed
Bug 1543560
Opened 6 years ago
Closed 6 years ago
Move NotifyWebRenderError() to CompositorManagerParent
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
During Bug 1533296, I saw a case that the NotifyWebRenderError() is called during mCanSend == false. It caused crash. We should not send ipc message during mCanSend == false.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•6 years ago
|
||
Hmm, it seems not good to handle NotifyWebRenderError() in CompositorBridgeParent, since CompositorBridgeParent is re-created for each nsBaseWidget::CreateCompositorSession(). It seems better to use CompositorManagerParent/CompositorManagerChild.
|
|
Assignee | |
Updated•6 years ago
|
Summary: Check mCanSend in CompositorBridgeParent::NotifyWebRenderError() → Move NotifyWebRenderError() to CompositorManagerParent
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/719725292e4c
Move NotifyWebRenderError() to CompositorManagerParent r=nical
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•