Closed Bug 1543560 Opened 5 months ago Closed 4 months ago

Move NotifyWebRenderError() to CompositorManagerParent

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

During Bug 1533296, I saw a case that the NotifyWebRenderError() is called during mCanSend == false. It caused crash. We should not send ipc message during mCanSend == false.

Assignee: nobody → sotaro.ikeda.g

Hmm, it seems not good to handle NotifyWebRenderError() in CompositorBridgeParent, since CompositorBridgeParent is re-created for each nsBaseWidget::CreateCompositorSession(). It seems better to use CompositorManagerParent/CompositorManagerChild.

Summary: Check mCanSend in CompositorBridgeParent::NotifyWebRenderError() → Move NotifyWebRenderError() to CompositorManagerParent
Blocks: 1533296
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/719725292e4c
Move NotifyWebRenderError() to CompositorManagerParent r=nical
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Depends on: 1546298
You need to log in before you can comment on or make changes to this bug.