1543806 - Incremental GC can block off-thread parsing

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Ted Campbell [:tcampbell]]

(Cloning from Bug 1543776 into JS component)

The following microbenchmark stalls offthread parsing while an incremental gc is occuring. This has shown up in page load profiles.

var doGC = true;

// Generate a long script to parse
fragment = " + a";
for (var i = 0; i < 19; ++i) {
    fragment = fragment + fragment;
}
offThreadScript = "var a = 2; var x = " + fragment + ";";

// Start incremental GC
if (doGC) {
  startgc(1);
}

// Start the off-thread
var jid = offThreadCompileScript(offThreadScript);

// Spin main-thread
for (var i = 0; i < 1000000; ++i) {
    with({}){} // Prevent IonMonkey
}

// Finish incremental GC
if (doGC) {
  finishgc();
}

// Wait for parse result
runOffThreadScript(jid);

Comment 1

[Ted Campbell [:tcampbell]]

Perf profiles imported into GeckoProfiler (thanks :jesup!)

Without_GC: https://perfht.ml/2UPvwFk
With_GC: https://perfht.ml/2UPwhya

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

FWIW, I'm testing https://hg.mozilla.org/try/rev/bc3d5ce21c69c5a270d488d1dbe8c37ae62337b6 and how it affects to tp6 and tp6m

Comment 3

[Nicolas B. Pierron [:nbp]]

Matthew, what is the progress around this issue?

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

In progress, but still a couple months out. I've added the meta bug I have been working under to the blockers list for this one, so the dependency tree is more clear.

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Using the microbenchmark Ted wrote in comment #1, modified to dump timing, I will note that I do still see delay introduced by the finishGC of ~500ms.

Comment 6

[Ted Campbell [:tcampbell]]

This Bug 1658631 landed this underlying issue is solved so I will close this bug. We haven't turned on by default in browser yet, but are working towards that soon in Bug 1662102.

tcampbell@ironman:~/projects/gecko.dev$ ./mach run stencil-bench.js 
Wall-time: 1224ms
tcampbell@ironman:~/projects/gecko.dev$ ./mach run --no-off-thread-parse-global stencil-bench.js 
Wall-time: 960ms