1658631 - Separate compilation to stencil, and instantiation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Once compilation to stencil stops touching GC things, the only part that touches GC things will be stencil instantiation (and some part that touches input GC things, that can be refactored in separate bug).

We can move the stencil instantiation part out of existing frontend API, so that helper thread can do only the compilation to stencil, and let the main thread instantiate the stencil.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 1: Add frontend::CompileGlobalScriptToStencil and frontend::InstantiateStencils. r?tcampbell!

CompileGlobalScriptToStencil returns CompilationStencil in CompilationInfo as the result of compilation,
and the consumer can call InstantiateStencils to instantiate GC objects,
that can be done later and in different thread.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 2: Add frontend::ParseModuleToStencil. r?tcampbell!

Depends on D88592

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 3: Support instantiating stencil in main thread for off-thread script/module compilation. r?tcampbell!

ParseTask generates CompilationInfo, that contains both input and stencil output.
and the main thread grabs it and instantiate it on the main thread, when finishting the compilation.

Depends on D88593

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 4: Instantiate stencil in main thread for off-thread module compilation. r?tcampbell!

Depends on D88594

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 7: Simplify main-thread API for CompileGlobalScript. r?tcampbell!

Stop exposing CompilationGCOutput where the consumer doesn't need to instantiate stencil in different step.

Depends on D88595

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 8: Simplify CompileEvalScript. r?tcampbell!

Depends on D88596

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 9: Rename module functions to align with others. r?tcampbell!

Compile{Foo} for public API, and Compile{Foo}Impl for internal template functions.

Depends on D88597

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 10: Do not call fixEnclosingEnvironmentAfterRealmMerge if useOffThreadParseGlobal is false. r?tcampbell!

Depends on D88598

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 11: Perform ModuleObject::Freeze in CompilationInfo::instantiateStencils if instantiating on main thread. r?tcampbell!

Depends on D88599

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 5: Make ParseTask.parseGlobal nullable. r?tcampbell!

Depends on D88594

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 6: Stop creating parse global if useOffThreadParseGlobal is set to false. r?tcampbell!

Depends on D88986

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1658631 - Part 4: Defer enclosingScope init for modules. r?tcampbell!

Depends on D88594

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a8df2bc7713
Part 1: Add frontend::CompileGlobalScriptToStencil and frontend::InstantiateStencils. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6cb5b3f713dd
Part 2: Add frontend::ParseModuleToStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/99f6e246e715
Part 3: Support instantiating stencil in main thread for off-thread script/module compilation. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/30679d02144c
Part 4: Defer enclosingScope init for modules. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c2dceacc711d
Part 5: Make ParseTask.parseGlobal nullable. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6420c7e18983
Part 6: Stop creating parse global if useOffThreadParseGlobal is set to false. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e1b43ff866ed
Part 7: Simplify main-thread API for CompileGlobalScript. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d6286e1b523b
Part 8: Simplify CompileEvalScript. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/855bd5d9ef0b
Part 9: Rename module functions to align with others. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d36b22eff759
Part 10: Do not call fixEnclosingEnvironmentAfterRealmMerge if useOffThreadParseGlobal is false. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/051b96a02b5a
Part 11: Perform ModuleObject::Freeze in CompilationInfo::instantiateStencils if instantiating on main thread. r=tcampbell

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/4a8df2bc7713
https://hg.mozilla.org/mozilla-central/rev/6cb5b3f713dd
https://hg.mozilla.org/mozilla-central/rev/99f6e246e715
https://hg.mozilla.org/mozilla-central/rev/30679d02144c
https://hg.mozilla.org/mozilla-central/rev/c2dceacc711d
https://hg.mozilla.org/mozilla-central/rev/6420c7e18983
https://hg.mozilla.org/mozilla-central/rev/e1b43ff866ed
https://hg.mozilla.org/mozilla-central/rev/d6286e1b523b
https://hg.mozilla.org/mozilla-central/rev/855bd5d9ef0b
https://hg.mozilla.org/mozilla-central/rev/d36b22eff759
https://hg.mozilla.org/mozilla-central/rev/051b96a02b5a