Closed Bug 1543823 Opened 6 months ago Closed 5 months ago

GV's Accept-Language HTTP header does not reflect the system language settings

Categories

(GeckoView :: General, defect, P1)

All
Android
defect

Tracking

(firefox66 wontfix, firefox67 wontfix, firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: cpeterson, Assigned: mbrubeck)

References

Details

(Whiteboard: [geckoview:fenix:m5])

Attachments

(1 file)

We should make Gecko's Accept-Language HTTP header automatically detect the system language settings or add a GV API for the app to set the Accept-Language values. Mozilla publishes different Fennec builds for different languages, but we only have one locale-agnostic GV build.

This language problem was reported in Fenix's issue tracker:
https://github.com/mozilla-mobile/fenix/issues/940

Accept-language uses Preferences::GetLocalizedCString. Does GV package have all localize data?

GV will be multi locale package, so https://searchfox.org/mozilla-central/source/mobile/android/chrome/content/browser.js#2165 is Fennec code. we need check intl.accept_languages prefs

Matt already added a GeckoRuntimeSetting for languages. Can GV just set the intl.accept_languages pref to update Accept-Languages?

Matt said he would investigate.

Assignee: nobody → mbrubeck
Priority: -- → P2
Whiteboard: [geckoview:fenix:m5]

See also Fennec bug 1542566 about Accept-Language.

See Also: → 1542566
Blocks: 1542566
See Also: 1542566

Randall says we should make sure this bug is fixed in FxR, too.

James says this bug should be a P0.

Priority: P2 → P1

This basic patch sets the Accept-Language header correctly on startup, and updates it when app prefs change. I'm still working on a follow-up patch to update the header when the OS prefs change.

Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/357afb475968
Compute Accept-Language header based on app and OS prefs. r=snorp
Regressions: 1552345
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.