1543823 - GV's Accept-Language HTTP header does not reflect the system language settings

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Chris Peterson [:cpeterson]]

We should make Gecko's Accept-Language HTTP header automatically detect the system language settings or add a GV API for the app to set the Accept-Language values. Mozilla publishes different Fennec builds for different languages, but we only have one locale-agnostic GV build.

Comment 1

[Chris Peterson [:cpeterson]]

This language problem was reported in Fenix's issue tracker:
https://github.com/mozilla-mobile/fenix/issues/940

Comment 2

[Makoto Kato [:m_kato]]

Accept-language uses Preferences::GetLocalizedCString. Does GV package have all localize data?

Comment 3

[Makoto Kato [:m_kato]]

GV will be multi locale package, so https://searchfox.org/mozilla-central/source/mobile/android/chrome/content/browser.js#2165 is Fennec code. we need check intl.accept_languages prefs

Comment 4

[Chris Peterson [:cpeterson]]

Matt already added a GeckoRuntimeSetting for languages. Can GV just set the intl.accept_languages pref to update Accept-Languages?

Matt said he would investigate.

Comment 5

[Chris Peterson [:cpeterson]]

See also Fennec bug 1542566 about Accept-Language.

Comment 6

[Chris Peterson [:cpeterson]]

Randall says we should make sure this bug is fixed in FxR, too.

James says this bug should be a P0.

Comment 7

[Philip Lamb]

This is P1 for FxR (https://github.com/MozillaReality/FirefoxReality/issues/786)

Comment 8

[Matt Brubeck (:mbrubeck)]

Attachment: Bug 1543823 - Compute Accept-Language header based on app and OS prefs. r?snorp

Comment 9

[Matt Brubeck (:mbrubeck)]

This basic patch sets the Accept-Language header correctly on startup, and updates it when app prefs change. I'm still working on a follow-up patch to update the header when the OS prefs change.

Comment 10

[Matt Brubeck (:mbrubeck)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67458478211376d4aa5e1d1d89e3bf263939a65b

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/357afb475968
Compute Accept-Language header based on app and OS prefs. r=snorp

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/357afb475968