1543839 - Let Resize Observer ride the trains (i.e. set pref 'layout.css.resizeobserver.enabled = true' without a NIGHTLY_BUILD guard)

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P2)

Description

[Daniel Holbert [:dholbert]]

Filing this bug to cover flipping the pref to enable the Resize Observer API (beyond Nightly builds -- i.e. let it ride the trains).

This bug should depend on:

• bug 1272409 (which has patches for the v1 API from a few years back)

• implementing the changes in the spec, since that bug's patches (including adding the 'options' field and making skippedTargets a list)

• any other bugs that come up during implementation that feel like they should block preffing this on.

Comment 1

[Daniel Holbert [:dholbert]]

(Also, we should send an intent-to-implement-and-ship at some point, with a reference to this bug.)

Comment 2

[Daniel Holbert [:dholbert]]

Updating comment 0 to reflect the fact that this is already enabled, in a restricted-to-Nightly way.

(This bug covers letting it be enabled beyond Nightly.)

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1543839 - Enable ResizeObserver preference by default on all versions.

Comment 4

[Boris Chiou [:boris]]

There is no new fuzz bug on ResizeObserver recently, and we are planning to ship ResizeObserver API (preffing on) in Firefox 69. So I will land this after got review approved.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 6

[Boris Chiou [:boris]]

Attachment: Bug 1543839 - Update test_interfaces.js for ResizeObserver.

Drop nightly true because it is enabled on all versions.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5143d7727109
Enable ResizeObserver preference by default on all versions. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/09614cb3a896
Update test_interfaces.js for ResizeObserver. r=smaug

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5143d7727109
https://hg.mozilla.org/mozilla-central/rev/09614cb3a896

Comment 9

[Chris Mills [:cmills]]

Documentation now completed for Resize Observer; see https://github.com/mdn/sprints/issues/1905#issuecomment-526296951 for the specifics of what got done.

Please can I get a review of the docs? Thanks!

Comment 10

[Boris Chiou [:boris]]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #9)

Documentation now completed for Resize Observer; see https://github.com/mdn/sprints/issues/1905#issuecomment-526296951 for the specifics of what got done.

Please can I get a review of the docs? Thanks!

It seems you just merge the browser compat data in the github, so the mdn pages haven't updated the browser compat data yet. However, for other parts, those pages look good to me.

Comment 11

[Chris Mills [:cmills]]

It seems you just merge the browser compat data in the github, so the mdn pages haven't updated the browser compat data yet. However, for other parts, those pages look good to me.

Thanks Boris!

Yes, we only launched the new browser-compat-data MDN package and updated MDN last night, so it'll take a few days for the new data to start appearing on the pages.